mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Radheka Godse <radheka.godse@intel.com>
To: bonding-devel@lists.sourceforge.net, fubar@us.ibm.com,
	ctindel@users.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [Bonding-devel][PATCH]Zero Copy Transmit Support (Update)
Date: Fri, 12 Nov 2004 15:51:49 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.61.0411121515530.15487@localhost.localdomain> (raw)

Please ignore previous submittal, it has reversed tags ('-'s instead of 
'+'s; I had swapped the order for diff of modified and un-modified 
src trees)

The patch below ADDS Zero Copy Transmit Support to bonding device.

We saw around ~50% system utilization improvement with tcp sendfile() 
function enabled netperf test in 802.3ad mode.

Note that this patch was generated for 2.6.9 kernel after applying 
bond-patch-2.6.1(also attached to this thread) that was submitted last week and 
got accepted into the kernel.

Signed-off-by: Radheka Godse <radheka.godse@intel.com>

diff -uprN -X dontdiff linux-2.6.9_bond-patch-2.6.1/drivers/net/bonding/bonding.h linux-2.6.9/drivers/net/bonding/bonding.h
--- linux-2.6.9_bond-patch-2.6.1/drivers/net/bonding/bonding.h	2004-11-10 15:42:55.000000000 -0800
+++ linux-2.6.9/drivers/net/bonding/bonding.h	2004-11-11 13:05:54.000000000 -0800
@@ -36,8 +36,8 @@
  #include "bond_3ad.h"
  #include "bond_alb.h"

-#define DRV_VERSION	"2.6.1"
-#define DRV_RELDATE	"October 29, 2004"
+#define DRV_VERSION	"2.6.2"
+#define DRV_RELDATE	"November 09, 2004"
  #define DRV_NAME	"bonding"
  #define DRV_DESCRIPTION	"Ethernet Channel Bonding Driver"

diff -uprN -X dontdiff linux-2.6.9_bond-patch-2.6.1/drivers/net/bonding/bond_main.c linux-2.6.9/drivers/net/bonding/bond_main.c
--- linux-2.6.9_bond-patch-2.6.1/drivers/net/bonding/bond_main.c	2004-11-10 15:42:55.000000000 -0800
+++ linux-2.6.9/drivers/net/bonding/bond_main.c	2004-11-11 13:05:54.000000000 -0800
@@ -475,6 +475,9 @@
   *        Solution is to move call to dev_remove_pack outside of the
   *        spinlock.
   *        Set version to 2.6.1.
+ * 2004/11/09 - Radheka Godse <radheka.godse at intel dot com>
+ *      - Added Zero Copy Transmit Support by setting appropriate flags.
+ *        Set version to 2.6.2.
   *
   */

@@ -4318,7 +4321,22 @@ static int __init bond_init(struct net_d
  	bond_dev->features |= (NETIF_F_HW_VLAN_TX |
  			       NETIF_F_HW_VLAN_RX |
  			       NETIF_F_HW_VLAN_FILTER);
-
+ 
+	/* We let the bond device publish all hardware
+	 * acceleration features possible. This is OK,
+	 * since if an skb is passed from the bond to
+	 * a slave that doesn't support one of those
+	 * features, everything is fixed in the
+	 * dev_queue_xmit() function (e.g. calculate
+	 * check sum, linearize the skb, etc.).
+	 */
+	bond_dev->features |= (NETIF_F_SG      |
+			       NETIF_F_IP_CSUM |
+			       NETIF_F_NO_CSUM |
+			       NETIF_F_HW_CSUM |
+			       NETIF_F_HIGHDMA |
+			       NETIF_F_FRAGLIST);
+
  #ifdef CONFIG_PROC_FS
  	bond_create_proc_entry(bond);
  #endif

             reply	other threads:[~2004-11-11 23:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-12 23:51 Radheka Godse [this message]
2004-11-12  0:00 ` David S. Miller
  -- strict thread matches above, loose matches on Subject: below --
2004-11-18 19:02 Godse, Radheka
2004-11-12 21:31 Godse, Radheka
2004-11-12 21:20 ` David S. Miller
2004-11-12 21:56   ` Jay Vosburgh
2004-11-12 21:49     ` David S. Miller
2004-11-12 22:20       ` Jay Vosburgh
2004-11-12 22:24         ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0411121515530.15487@localhost.localdomain \
    --to=radheka.godse@intel.com \
    --cc=bonding-devel@lists.sourceforge.net \
    --cc=ctindel@users.sourceforge.net \
    --cc=fubar@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®