From: Jesper Juhl <juhl@dif.dk>
To: "Luiz Fernando N. Capitulino" <lcapitulino@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, davem@davemloft.net
Subject: Re: [PATCH 1/2] - net/socket.c::sys_bind() cleanup.
Date: Wed, 17 Nov 2004 01:52:08 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.61.0411170109020.3444@dragon.hygekrogen.localhost> (raw)
In-Reply-To: <20041116185517.3314ac35.lcapitulino@conectiva.com.br>
On Tue, 16 Nov 2004, Luiz Fernando N. Capitulino wrote:
>
> Hi,
>
> net/socket.c::sys_bind() is a bit complex function, the patch
> bellow makes it more clear.
>
> Note that the code does the same thing, it only makes difference
> for the programmer.
>
Not exactely :
> - if((err=move_addr_to_kernel(umyaddr,addrlen,address))>=0) {
> + err = move_addr_to_kernel(umyaddr, addrlen, address);
> + if (err)
> + goto out_put;
The original tests for err >= 0, your replacement tests if err is != 0
--
Jesper Juhl
next prev parent reply other threads:[~2004-11-17 0:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 20:55 Luiz Fernando N. Capitulino
2004-11-17 0:52 ` Jesper Juhl [this message]
2004-11-17 4:16 ` James Morris
2004-11-17 9:55 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0411170109020.3444@dragon.hygekrogen.localhost \
--to=juhl@dif.dk \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=lcapitulino@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®