From: Jesper Juhl <juhl-lkml@dif.dk>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Remove pointless <0 comparison for unsigned variable in fs/fcntl.c
Date: Sun, 21 Nov 2004 23:55:23 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.61.0411212351210.3423@dragon.hygekrogen.localhost> (raw)
Hi,
This patch removes a pointless comparison. "arg" is an unsigned long, thus
it can never be <0, so testing that is pointless.
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
diff -up linux-2.6.10-rc2-bk6-orig/fs/fcntl.c linux-2.6.10-rc2-bk6/fs/fcntl.c
--- linux-2.6.10-rc2-bk6-orig/fs/fcntl.c 2004-11-17 01:20:14.000000000 +0100
+++ linux-2.6.10-rc2-bk6/fs/fcntl.c 2004-11-21 23:49:20.000000000 +0100
@@ -340,7 +340,7 @@ static long do_fcntl(int fd, unsigned in
break;
case F_SETSIG:
/* arg == 0 restores default behaviour. */
- if (arg < 0 || arg > _NSIG) {
+ if (arg > _NSIG) {
break;
}
err = 0;
next reply other threads:[~2004-11-21 22:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 22:55 Jesper Juhl [this message]
2004-11-22 1:02 ` Matthew Wilcox
2004-11-23 9:42 ` Jesper Juhl
2004-11-23 10:42 ` Jamie Lokier
2004-11-23 18:28 ` Bryan Henderson
2004-11-23 18:03 ` Linus Torvalds
2004-11-23 18:39 ` Jesper Juhl
2004-11-23 18:37 ` Linus Torvalds
2004-11-23 19:20 ` linux-os
2004-11-23 23:16 ` Jesper Juhl
2004-11-23 19:13 ` Timur Tabi
2004-11-23 23:09 ` Jesper Juhl
2004-11-23 23:03 ` Timur Tabi
2004-11-23 23:19 ` Jesper Juhl
2004-11-23 23:09 ` Timur Tabi
2004-11-23 23:28 ` Jesper Juhl
2004-11-25 22:34 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0411212351210.3423@dragon.hygekrogen.localhost \
--to=juhl-lkml@dif.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®