From: Jesper Juhl <juhl-lkml@dif.dk>
To: Pavel Machek <pavel@suse.cz>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Linux Kernel Trivial Patch Monkey <trivial@rustcorp.com.au>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 0/30] return statement cleanup - kill pointless parentheses
Date: Thu, 16 Dec 2004 02:16:11 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.61.0412160213140.3864@dragon.hygekrogen.localhost> (raw)
In-Reply-To: <20041216010012.GB6285@elf.ucw.cz>
On Thu, 16 Dec 2004, Pavel Machek wrote:
> Hi!
>
> > Ok, here's the first batch of return statement cleanups (*many* to go).
> >
> > The following patches clean up return statements of the forms
> > return(foo);
> > return ( fn() );
> > return (123);
> > return(a + b);
> > etc. To be instead
> > return foo;
> > return fn();
> > return 123
> > return a + b;
>
> Yes, I like that. Please also go through drivers/acpi -- there's lot
> of annoying parenthesis there ;-).
> Pavel
Sure thing, I'll add that to my must_do list :)
There seems to be very mixed feelings about this, so I think what I'll do
is to pick a few files from different dirs and submit patches for them, if
I then get positive feedback I'll do more in that dir, if not I'll just
leave it.
Thank you for responding.
--
Jesper Juhl
next prev parent reply other threads:[~2004-12-16 1:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-16 0:02 Jesper Juhl
2004-12-16 1:00 ` Pavel Machek
2004-12-16 1:16 ` Jesper Juhl [this message]
2004-12-16 10:16 ` Arnd Bergmann
2004-12-16 14:27 ` [PATCH 0/30] return statement cleanup - kill pointless parent heses Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0412160213140.3864@dragon.hygekrogen.localhost \
--to=juhl-lkml@dif.dk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®