mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Armin Schindler <armin@melware.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: isdn4linux@listserv.isdn4linux.de,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	developers@melware.de
Subject: Re: [2.6 patch] drivers/isdn/hardware/eicon/: misc possible cleanups
Date: Wed, 9 Feb 2005 08:38:18 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.61.0502090828550.8366@phoenix.one.melware.de> (raw)
In-Reply-To: <20050209014235.GA2978@stusta.de>

On Wed, 9 Feb 2005, Adrian Bunk wrote:
> On Sun, Feb 06, 2005 at 11:18:18AM +0100, Armin Schindler wrote:
> 
> > Hi Adrian,
> 
> Hi Armin,
> 
> > thanks for the proposed patch.
> > Making the functions static is a good idea, I will check and test this.
> > Removing some functions, especially from io.* and di.* is not good. These 
> > functions are mainly used with other sub-drivers which are not part of the
> > kernel. I will check if they are some really outdated and the removals in 
> > message.c.
> 
> silly question:
> Why are these sub-drivers not included in the kernel?

These drivers are for older cards and are not fully ported to kernel 2.6. 
I never really intended to put this old stuff into kernel 2.6.
The code of io.* and di.* is common code for all supported platforms, so I
always try to reduce changes here.
Like my last patch, I will try to remove unused code in linux with a
preparser in my code-controller. So eventually the mentioned code is really
unsused and can be removed. 
I will check all this in the next days and prepare a new patch.

Armin


      reply	other threads:[~2005-02-09  7:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-06  0:35 Adrian Bunk
2005-02-06 10:18 ` Armin Schindler
2005-02-09  1:42   ` Adrian Bunk
2005-02-09  7:38     ` Armin Schindler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0502090828550.8366@phoenix.one.melware.de \
    --to=armin@melware.de \
    --cc=bunk@stusta.de \
    --cc=developers@melware.de \
    --cc=isdn4linux@listserv.isdn4linux.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®