From: Hugh Dickins <hugh@veritas.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andi Kleen <ak@suse.de>, "David S. Miller" <davem@davemloft.net>,
benh@kernel.crashing.org, torvalds@osdl.org, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] page table iterators
Date: Thu, 24 Feb 2005 11:58:42 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.61.0502241143001.6630@goblin.wat.veritas.com> (raw)
In-Reply-To: <1109224777.5177.33.camel@npiggin-nld.site>
On Thu, 24 Feb 2005, Nick Piggin wrote:
>
> pud_addr_end?
next = pud_addr_end(addr, end);
Hmm, yes, I'll go with that, thanks (unless a better idea follows).
Something I do intend on top of what I sent before, is another set
of three macros, like
if (pud_none_or_clear_bad(pud))
continue;
to replace all the p??_none, p??_bad clauses: not to save space,
but just for clarity, those loops now seeming dominated by the
unlikeliest of cases.
Has anyone _ever_ seen a p??_ERROR message? I'm inclined to just
put three functions into mm/memory.c to do the p??_ERROR and p??_clear,
but that way the __FILE__ and __LINE__ will always come out the same.
I think if it ever proves a problem, we'd just add in a dump_stack.
Hugh
next prev parent reply other threads:[~2005-02-24 11:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-17 13:53 [PATCH 1/2] optimise copy page range Nick Piggin
2005-02-17 14:03 ` [PATCH 2/2] page table iterators Nick Piggin
2005-02-17 15:56 ` Linus Torvalds
2005-02-17 16:13 ` Nick Piggin
2005-02-17 19:43 ` Andi Kleen
2005-02-17 22:49 ` Benjamin Herrenschmidt
2005-02-17 23:03 ` Andi Kleen
2005-02-17 23:21 ` Benjamin Herrenschmidt
2005-02-17 23:34 ` Andi Kleen
2005-02-17 23:30 ` David S. Miller
2005-02-17 23:57 ` Andi Kleen
2005-02-20 12:35 ` Nick Piggin
2005-02-21 6:35 ` Hugh Dickins
2005-02-21 6:40 ` Andrew Morton
2005-02-21 7:09 ` Benjamin Herrenschmidt
2005-02-21 8:09 ` Nick Piggin
2005-02-21 9:04 ` Nick Piggin
2005-02-22 9:54 ` Nick Piggin
2005-02-23 2:06 ` Hugh Dickins
2005-02-23 4:31 ` David S. Miller
2005-02-23 4:49 ` Nick Piggin
2005-02-23 4:57 ` David S. Miller
2005-02-23 5:23 ` Nick Piggin
2005-02-23 23:52 ` Nick Piggin
2005-02-24 0:00 ` David S. Miller
2005-02-24 5:12 ` Hugh Dickins
2005-02-24 5:59 ` Nick Piggin
2005-02-24 11:58 ` Hugh Dickins [this message]
2005-02-24 19:33 ` David S. Miller
2005-02-25 10:44 ` Andi Kleen
2005-02-24 21:59 ` Nick Piggin
2005-02-24 22:32 ` Hugh Dickins
2005-02-24 22:52 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0502241143001.6630@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®