mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	Russell King <rmk@arm.linux.org.uk>,
	David Howells <dhowells@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR
Date: Thu, 7 Apr 2005 02:13:10 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.61.0504070210430.24723@goblin.wat.veritas.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0504070204390.24723@goblin.wat.veritas.com>

Remove use of FIRST_USER_PGD_NR from sys_mincore: it's inconsistent (no
other syscall refers to it), unnecessary (sys_mincore loops over vmas
further down) and incorrect (misses user addresses in ARM's first pgd).

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---

 mm/mincore.c |    3 ---
 1 files changed, 3 deletions(-)

--- 2.6.12-rc2-mm1/mm/mincore.c	2005-04-05 15:21:02.000000000 +0100
+++ linux/mm/mincore.c	2005-04-05 18:59:01.000000000 +0100
@@ -118,9 +118,6 @@ asmlinkage long sys_mincore(unsigned lon
  	if (start & ~PAGE_CACHE_MASK)
 		goto einval;
 
-	if (start < FIRST_USER_PGD_NR * PGDIR_SIZE)
-		goto enomem;
-
 	limit = TASK_SIZE;
 	if (start >= limit)
 		goto enomem;

  reply	other threads:[~2005-04-07  1:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-07  1:10 [PATCH 1/6] freepgt2: free_pgtables from FIRST_USER_ADDRESS Hugh Dickins
2005-04-07  1:13 ` Hugh Dickins [this message]
2005-04-07  1:14 ` [PATCH 3/6] freepgt2: arm FIRST_USER_ADDRESS PAGE_SIZE Hugh Dickins
2005-04-07  1:16 ` [PATCH 4/6] freepgt2: arm26 " Hugh Dickins
2005-04-07  2:22   ` Ian Molton
2005-04-07  1:18 ` [PATCH 5/6] freepgt2: arch FIRST_USER_ADDRESS 0 Hugh Dickins
2005-04-07  1:19 ` [PATCH 6/6] freepgt2: remove FIRST_USER_ADDRESS hack Hugh Dickins
2005-04-07 10:14 ` [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR David Howells
2005-04-07 14:31   ` Nick Piggin
2005-04-08  3:40     ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0504070210430.24723@goblin.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=akpm@osdl.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®