From: Hugh Dickins <hugh@veritas.com>
To: Guo Racing <racing.guo@intel.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] porting lockless mce from x86_64 to i386
Date: Thu, 19 May 2005 18:48:44 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.61.0505191834480.13030@goblin.wat.veritas.com> (raw)
In-Reply-To: <1116495706.18666.55.camel@guorj.sh.intel.com>
On Thu, 19 May 2005, Guo Racing wrote:
> Lockless MCE(machine check exception) is ported from
> x86-64 to i386. This patch is for implementation.
You seem to be missing most of the issues people raise:
perhaps your spamfilter is too eager.
Where is Brice Goglin's #include <asm/apic.h> in mce_intel.c?
i386 machine_check_init misses calling mcheck_init in Intel
and Centaur cases, so a lot of the code is largely untested.
You need to avoid the P6 and AMD problems with bank0,
as the replaced code did.
I fear there may be more.
Hugh
prev parent reply other threads:[~2005-05-21 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 9:35 [PATCH 1/2] " Guo Racing
2005-05-19 9:41 ` [PATCH 2/2] " Guo Racing
2005-05-19 17:48 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0505191834480.13030@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=racing.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome