From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Lameter <clameter@sgi.com>,
Shai Fultheim <shai@scalex86.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] do_wp_page: cannot share file page
Date: Mon, 6 Jun 2005 20:57:57 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.61.0506062055350.5000@goblin.wat.veritas.com> (raw)
A small optimization to do_wp_page's check for whether to avoid copy by
reusing the page already mapped. It can never share a cached file page,
nor can it share a reserved page (often the empty zero page), so it's a
waste of time to lock and unlock in those cases. Which nowadays can
both be neatly excluded by a preliminary PageAnon test.
Christoph has reported that a preliminary page_count test proved valuable
for scalability here, but PageAnon covers more common cases all at once.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
mm/memory.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- 2.6.12-rc6/mm/memory.c 2005-05-25 18:09:21.000000000 +0100
+++ linux/mm/memory.c 2005-06-04 20:41:55.000000000 +0100
@@ -1264,7 +1264,7 @@ static int do_wp_page(struct mm_struct *
}
old_page = pfn_to_page(pfn);
- if (!TestSetPageLocked(old_page)) {
+ if (PageAnon(old_page) && !TestSetPageLocked(old_page)) {
int reuse = can_share_swap_page(old_page);
unlock_page(old_page);
if (reuse) {
next reply other threads:[~2005-06-06 20:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-06 19:57 Hugh Dickins [this message]
2005-06-06 20:00 ` [PATCH 2/2] can_share_swap_page: use page_mapcount Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0506062055350.5000@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®