From: Zwane Mwaikambo <zwane@arm.linux.org.uk>
To: Andi Kleen <ak@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] i386 !NUMA node_to_cpumask broken in early boot
Date: Thu, 18 Aug 2005 20:49:52 -0600 (MDT) [thread overview]
Message-ID: <Pine.LNX.4.61.0508182043310.28588@montezuma.fsmlabs.com> (raw)
In-Reply-To: <20050819021216.GF22993@wotan.suse.de>
On Fri, 19 Aug 2005, Andi Kleen wrote:
> On Thu, Aug 18, 2005 at 08:07:53PM -0600, Zwane Mwaikambo wrote:
> > node_to_cpumask on non NUMA systems is broken if used before all the
> > processors have been brought up as it returns cpu_online_map, as opposed
> > to NUMA i386 systems which does it earlier than AP bringup. So return
> > which processors responded via cpu_present_map and switch to
> > cpu_online_map during normal runtime. This was found whilst testing a
> > patch which does node dependent work before APs have all gone online.
>
> Very ugly and will probably cause code bloat.
>
> If anything define a special early_node_to ... function for this.
Thanks for the feedback, ugly indeed, i was really trying to avoid adding
a new API function or extra cpu_* variables. Ok, here is an
early_node_to_cpumask instead.
Signed-off-by: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Index: linux-2.6.13-rc5-mm1/include/asm-i386/topology.h
===================================================================
RCS file: /home/cvsroot/linux-2.6.13-rc5-mm1/include/asm-i386/topology.h,v
retrieving revision 1.1.1.1
diff -u -p -B -r1.1.1.1 topology.h
--- linux-2.6.13-rc5-mm1/include/asm-i386/topology.h 7 Aug 2005 21:38:36 -0000 1.1.1.1
+++ linux-2.6.13-rc5-mm1/include/asm-i386/topology.h 19 Aug 2005 02:47:10 -0000
@@ -92,6 +92,7 @@ extern unsigned long node_end_pfn[];
extern unsigned long node_remap_size[];
#define node_has_online_mem(nid) (node_start_pfn[nid] != node_end_pfn[nid])
+#define early_node_to_cpumask(nid) node_to_cpumask(nid)
#else /* !CONFIG_NUMA */
/*
@@ -99,6 +100,14 @@ extern unsigned long node_remap_size[];
* above macros here.
*/
+static inline cpumask_t early_node_to_cpumask(int nid)
+{
+ if (unlikely(system_state == SYSTEM_BOOTING))
+ return cpu_present_map;
+
+ return cpu_online_map;
+}
+
#include <asm-generic/topology.h>
#endif /* CONFIG_NUMA */
next prev parent reply other threads:[~2005-08-19 2:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-19 2:07 Zwane Mwaikambo
2005-08-19 2:12 ` Andi Kleen
2005-08-19 2:49 ` Zwane Mwaikambo [this message]
2005-08-19 3:06 ` Andi Kleen
2005-08-19 3:27 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0508182043310.28588@montezuma.fsmlabs.com \
--to=zwane@arm.linux.org.uk \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®