From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932703AbVISVbR (ORCPT ); Mon, 19 Sep 2005 17:31:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932707AbVISVbR (ORCPT ); Mon, 19 Sep 2005 17:31:17 -0400 Received: from silver.veritas.com ([143.127.12.111]:53551 "EHLO silver.veritas.com") by vger.kernel.org with ESMTP id S932703AbVISVbQ (ORCPT ); Mon, 19 Sep 2005 17:31:16 -0400 Date: Mon, 19 Sep 2005 22:30:32 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@goblin.wat.veritas.com To: Linus Torvalds cc: Smarduch Mario-CMS063 , linux-kernel@vger.kernel.org Subject: Re: Multi-Threaded fork() correctness on Linux 2.4 & 2.6 In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 19 Sep 2005 21:31:13.0680 (UTC) FILETIME=[75DCA900:01C5BD61] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Sep 2005, Linus Torvalds wrote: > > Hmm. But we do hold the mmap_sem for writing, and we flush before we > release it, so it should still be ok. The page fault case needs to get it > for reading anyway. > > Yeah, the page_table_lock might make more sense, but I think the mmap_sem > thing works equally well. Yes, you're both ahead of me: thank you for working that out: no issue. Hugh