mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Adam Litke <agl@us.ibm.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	William Irwin <wli@holomorphy.com>,
	Ken Chen <kenneth.w.chen@intel.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 22/21] mm: fix unmap_vmas with inner ptlock
Date: Fri, 14 Oct 2005 23:59:07 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.61.0510142355560.20844@goblin.wat.veritas.com> (raw)

He who lectures others about hugetlbfs truncation might discover that
it's got screwed by his very own self.  I replaced zap_hugepage_range by
unmap_hugepage_range, overlooking that zap used "len" but unmap "end".

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---

 fs/hugetlbfs/inode.c |    6 +-----
 1 files changed, 1 insertion(+), 5 deletions(-)

--- mm21/fs/hugetlbfs/inode.c	2005-10-11 23:57:59.000000000 +0100
+++ mm22/fs/hugetlbfs/inode.c	2005-10-14 23:28:42.000000000 +0100
@@ -284,7 +284,6 @@ hugetlb_vmtruncate_list(struct prio_tree
 
 	vma_prio_tree_foreach(vma, &iter, root, h_pgoff, ULONG_MAX) {
 		unsigned long h_vm_pgoff;
-		unsigned long v_length;
 		unsigned long v_offset;
 
 		h_vm_pgoff = vma->vm_pgoff >> (HPAGE_SHIFT - PAGE_SHIFT);
@@ -295,11 +294,8 @@ hugetlb_vmtruncate_list(struct prio_tree
 		if (h_vm_pgoff >= h_pgoff)
 			v_offset = 0;
 
-		v_length = vma->vm_end - vma->vm_start;
-
 		unmap_hugepage_range(vma,
-				vma->vm_start + v_offset,
-				v_length - v_offset);
+				vma->vm_start + v_offset, vma->vm_end);
 	}
 }
 

                 reply	other threads:[~2005-10-14 23:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0510142355560.20844@goblin.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=agl@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®