From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: reiserfs-dev@namesys.com, linux-kernel@vger.kernel.org
Subject: [PATCH 03/15] mm reiser4: revert page_private
Date: Thu, 10 Nov 2005 01:46:04 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.61.0511100144360.5814@goblin.wat.veritas.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0511100139550.5814@goblin.wat.veritas.com>
Revert page_private: remove -mm tree's reiser4-page-private-fixes.patch
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
fs/reiser4/flush_queue.c | 2 +-
fs/reiser4/jnode.c | 10 +++++-----
fs/reiser4/page_cache.c | 2 +-
fs/reiser4/page_cache.h | 2 +-
fs/reiser4/plugin/file/tail_conversion.c | 2 +-
fs/reiser4/txnmgr.c | 6 +++---
6 files changed, 12 insertions(+), 12 deletions(-)
--- mm02/fs/reiser4/flush_queue.c 2005-11-07 07:39:46.000000000 +0000
+++ mm03/fs/reiser4/flush_queue.c 2005-11-09 14:38:18.000000000 +0000
@@ -427,7 +427,7 @@ end_io_handler(struct bio *bio, unsigned
assert("zam-736", pg != NULL);
assert("zam-736", PagePrivate(pg));
- node = jprivate(pg);
+ node = (jnode *) (pg->private);
JF_CLR(node, JNODE_WRITEBACK);
}
--- mm02/fs/reiser4/jnode.c 2005-11-07 07:39:46.000000000 +0000
+++ mm03/fs/reiser4/jnode.c 2005-11-09 14:38:18.000000000 +0000
@@ -38,12 +38,12 @@
* page_address().
*
* jnode and page are attached to each other by jnode_attach_page(). This
- * function places pointer to jnode in page_private(), sets PG_private flag
+ * function places pointer to jnode in page->private, sets PG_private flag
* and increments page counter.
*
* Opposite operation is performed by page_clear_jnode().
*
- * jnode->pg is protected by jnode spin lock, and page_private() is
+ * jnode->pg is protected by jnode spin lock, and page->private is
* protected by page lock. See comment at the top of page_cache.c for
* more.
*
@@ -664,7 +664,7 @@ void jnode_attach_page(jnode * node, str
assert("nikita-2060", node != NULL);
assert("nikita-2061", pg != NULL);
- assert("nikita-2050", page_private(pg) == 0ul);
+ assert("nikita-2050", pg->private == 0ul);
assert("nikita-2393", !PagePrivate(pg));
assert("vs-1741", node->pg == NULL);
@@ -672,7 +672,7 @@ void jnode_attach_page(jnode * node, str
assert("nikita-2397", spin_jnode_is_locked(node));
page_cache_get(pg);
- set_page_private(pg, (unsigned long)node);
+ pg->private = (unsigned long)node;
node->pg = pg;
SetPagePrivate(pg);
}
@@ -689,7 +689,7 @@ void page_clear_jnode(struct page *page,
assert("nikita-3551", !PageWriteback(page));
JF_CLR(node, JNODE_PARSED);
- set_page_private(page, 0ul);
+ page->private = 0ul;
ClearPagePrivate(page);
node->pg = NULL;
page_cache_release(page);
--- mm02/fs/reiser4/page_cache.c 2005-11-07 07:39:46.000000000 +0000
+++ mm03/fs/reiser4/page_cache.c 2005-11-09 14:38:18.000000000 +0000
@@ -753,7 +753,7 @@ void print_page(const char *prefix, stru
}
printk("%s: page index: %lu mapping: %p count: %i private: %lx\n",
prefix, page->index, page->mapping, page_count(page),
- page_private(page));
+ page->private);
printk("\tflags: %s%s%s%s %s%s%s %s%s%s %s%s\n",
page_flag_name(page, PG_locked), page_flag_name(page, PG_error),
page_flag_name(page, PG_referenced), page_flag_name(page,
--- mm02/fs/reiser4/page_cache.h 2005-11-07 07:39:46.000000000 +0000
+++ mm03/fs/reiser4/page_cache.h 2005-11-09 14:38:18.000000000 +0000
@@ -30,7 +30,7 @@ static inline void lock_and_wait_page_wr
reiser4_wait_page_writeback(page);
}
-#define jprivate(page) ((jnode *) page_private(page))
+#define jprivate(page) ((jnode *) (page)->private)
extern int page_io(struct page *page, jnode * node, int rw, int gfp);
extern void drop_page(struct page *page);
--- mm02/fs/reiser4/plugin/file/tail_conversion.c 2005-11-07 07:39:46.000000000 +0000
+++ mm03/fs/reiser4/plugin/file/tail_conversion.c 2005-11-09 14:38:18.000000000 +0000
@@ -670,7 +670,7 @@ int extent2tail(unix_file_info_t * uf_in
/* page is already detached from jnode and mapping. */
assert("vs-1086", page->mapping == NULL);
assert("nikita-2690",
- (!PagePrivate(page) && page_private(page) == 0));
+ (!PagePrivate(page) && page->private == 0));
/* waiting for writeback completion with page lock held is
* perfectly valid. */
wait_on_page_writeback(page);
--- mm02/fs/reiser4/txnmgr.c 2005-11-07 07:39:46.000000000 +0000
+++ mm03/fs/reiser4/txnmgr.c 2005-11-09 14:38:18.000000000 +0000
@@ -2331,7 +2331,7 @@ void uncapture_page(struct page *pg)
reiser4_wait_page_writeback(pg);
- node = jprivate(pg);
+ node = (jnode *) (pg->private);
BUG_ON(node == NULL);
LOCK_JNODE(node);
@@ -3603,14 +3603,14 @@ static void swap_jnode_pages(jnode * nod
copy->pg = node->pg;
copy->data = page_address(copy->pg);
jnode_set_block(copy, jnode_get_block(node));
- set_page_private(copy->pg, (unsigned long)copy);
+ copy->pg->private = (unsigned long)copy;
/* attach new page to jnode */
assert("vs-1412", !PagePrivate(new_page));
page_cache_get(new_page);
node->pg = new_page;
node->data = page_address(new_page);
- set_page_private(new_page, (unsigned long)node);
+ new_page->private = (unsigned long)node;
SetPagePrivate(new_page);
{
next prev parent reply other threads:[~2005-11-10 1:47 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-10 1:42 [PATCH 00/15] mm: struct page lock and counts Hugh Dickins
2005-11-10 1:43 ` [PATCH 01/15] mm: poison struct page for ptlock Hugh Dickins
2005-11-10 2:10 ` Andrew Morton
2005-11-10 2:22 ` Hugh Dickins
2005-11-10 2:56 ` Andrew Morton
2005-11-10 2:58 ` Andrew Morton
2005-11-10 11:28 ` Ingo Molnar
2005-11-10 12:06 ` Ingo Molnar
2005-11-10 12:26 ` Andrew Morton
2005-11-10 21:37 ` Christoph Lameter
2005-11-10 21:52 ` Christoph Hellwig
2005-11-11 10:46 ` Ingo Molnar
2005-11-12 23:48 ` Adrian Bunk
2005-11-10 12:35 ` Hugh Dickins
2005-11-10 12:51 ` Andrew Morton
2005-11-10 13:29 ` Hugh Dickins
2005-11-10 15:00 ` Ingo Molnar
2005-11-10 15:38 ` Hugh Dickins
2005-11-10 19:49 ` Andrew Morton
2005-11-10 19:56 ` Linus Torvalds
2005-11-11 0:10 ` Russell King
2005-11-12 6:27 ` Benjamin Herrenschmidt
2005-11-11 15:02 ` Hugh Dickins
2005-11-15 18:49 ` Andrew Morton
2005-11-15 19:51 ` Hugh Dickins
2005-11-15 20:05 ` Andrew Morton
2005-11-10 1:44 ` [PATCH 02/15] mm: revert page_private Hugh Dickins
2005-11-10 1:46 ` Hugh Dickins [this message]
2005-11-10 1:47 ` [PATCH 04/15] mm: update split ptlock Kconfig Hugh Dickins
2005-11-10 1:48 ` [PATCH 05/15] mm: unbloat get_futex_key Hugh Dickins
2005-11-10 1:50 ` [PATCH 06/15] mm: remove ppc highpte Hugh Dickins
2005-11-10 1:52 ` Benjamin Herrenschmidt
2005-11-10 1:55 ` Paul Mackerras
2005-11-10 2:46 ` Hugh Dickins
2005-11-10 1:51 ` [PATCH 07/15] mm: powerpc ptlock comments Hugh Dickins
2005-11-10 1:53 ` [PATCH 08/15] mm: powerpc init_mm without ptlock Hugh Dickins
2005-11-10 1:56 ` [PATCH 09/15] mm: fill arch atomic64 gaps Hugh Dickins
2005-11-10 13:38 ` Andi Kleen
2005-11-10 15:19 ` Hugh Dickins
2005-11-10 1:57 ` [PATCH 10/15] mm: atomic64 page counts Hugh Dickins
2005-11-10 2:16 ` Andrew Morton
2005-11-10 2:33 ` Hugh Dickins
2005-11-10 3:01 ` Andrew Morton
2005-11-10 21:43 ` Christoph Lameter
2005-11-10 21:53 ` Andrew Morton
2005-11-11 15:25 ` Hugh Dickins
2005-11-11 18:03 ` Christoph Lameter
2005-11-10 2:00 ` [PATCH 11/15] mm: long " Hugh Dickins
2005-11-10 2:01 ` [PATCH 12/15] mm reiser4: " Hugh Dickins
2005-11-10 2:03 ` [PATCH 13/15] mm: get_user_pages check count Hugh Dickins
2005-11-10 2:08 ` [PATCH 14/15] mm: inc_page_table_pages check max Hugh Dickins
2005-11-10 2:09 ` [PATCH 15/15] mm: remove install_page limit Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0511100144360.5814@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-dev@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®