From: Hugh Dickins <hugh@veritas.com>
To: Michael Frank <mhf@berlios.de>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>,
Benoit Boissinot <benoit.boissinot@ens-lyon.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Michael Krufky <mkrufky@m1k.net>, Andrew Morton <akpm@osdl.org>,
Dave Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.15-rc1-mm2 0x414 Bad page states
Date: Tue, 22 Nov 2005 21:32:42 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.61.0511222124040.29784@goblin.wat.veritas.com> (raw)
In-Reply-To: <20051122211625.165F114CB@hornet.berlios.de>
On Tue, 22 Nov 2005, Michael Frank wrote:
>
> I am getting this also with i810 drm in Vanilla 2.6.15-rc2
> upon exiting apps such as supertux.
Aha, perhaps you're the one we've been waiting for. I've suspected
a DRM issue, but nobody has actually seen one until now, and I didn't
want to put in a patch without live justification.
Would you please try the patch below, and let us know if it fixes your
problem. If so, I'll send it off to Andrew and Linus: the rest of the
PageReserved fixes, including the sound driver Bad page state fixes,
have gone into Linus' git tree today: perhaps this is the missing piece.
If this does not work for you, then presumably you'd be another sound
driver sufferer? and I should send you that patch (or you pick it up
from yesterday's LKML). But right now I'd selfishly like you to test
just this DRM patch below.
Thanks,
Hugh
--- 2.6.15-rc2/drivers/char/drm/drm_memory.c 2005-11-20 19:43:39.000000000 +0000
+++ linux/drivers/char/drm/drm_memory.c 2005-11-21 10:10:45.000000000 +0000
@@ -95,7 +95,7 @@ unsigned long drm_alloc_pages(int order,
unsigned long addr;
unsigned int sz;
- address = __get_free_pages(GFP_KERNEL, order);
+ address = __get_free_pages(GFP_KERNEL|__GFP_COMP, order);
if (!address)
return 0;
--- 2.6.15-rc2/drivers/char/drm/drm_memory_debug.h 2005-11-20 19:43:39.000000000 +0000
+++ linux/drivers/char/drm/drm_memory_debug.h 2005-11-21 10:11:04.000000000 +0000
@@ -221,7 +221,7 @@ unsigned long DRM(alloc_pages) (int orde
}
spin_unlock(&DRM(mem_lock));
- address = __get_free_pages(GFP_KERNEL, order);
+ address = __get_free_pages(GFP_KERNEL|__GFP_COMP, order);
if (!address) {
spin_lock(&DRM(mem_lock));
++DRM(mem_stats)[area].fail_count;
next prev parent reply other threads:[~2005-11-22 21:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 19:15 Hugh Dickins
2005-11-18 20:12 ` Dominik Brodowski
2005-11-18 20:42 ` Rafael J. Wysocki
2005-11-19 4:30 ` Nick Piggin
2005-11-19 4:33 ` Nick Piggin
[not found] ` <Pine.LNX.4.61.0511182214200.4797@goblin.wat.veritas.com>
2005-11-19 19:57 ` Hugh Dickins
2005-11-19 22:42 ` Dominik Brodowski
2005-11-20 10:14 ` Marc Koschewski
2005-11-21 13:02 ` Christian Kujau
[not found] ` <20051122211625.165F114CB@hornet.berlios.de>
2005-11-22 21:32 ` Hugh Dickins [this message]
[not found] ` <20051122231603.2209814DA@hornet.berlios.de>
2005-11-23 11:07 ` Dave Airlie
2005-11-23 20:33 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0511222124040.29784@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=airlied@gmail.com \
--cc=akpm@osdl.org \
--cc=benoit.boissinot@ens-lyon.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mhf@berlios.de \
--cc=mkrufky@m1k.net \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®