mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Jacek Luczak <difrost@pin.if.uz.zgora.pl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.6.15-rc5 and Alsa 1.0.10
Date: Fri, 9 Dec 2005 16:14:54 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.61.0512091610160.24942@goblin.wat.veritas.com> (raw)
In-Reply-To: <4399B195.9050801@pin.if.uz.zgora.pl>

On Fri, 9 Dec 2005, Jacek Luczak wrote:
> 
> I'm using now 2.6.15-rc5 kernel with latest Alsa 1.0.10 and I received a lot
> of 'bad page state at free_hot_cold_page' (see example below) messages. Is
> this kernel or alsa error?
> 
> System:
> Slackware Linux, GCC 3.4.4, Binutils 2.16.1.
> CPU: Pentium 4 3Ghz HT
> Sound card: CMI9880 (HDA)
> 
> Dec  9 16:53:20 slawek kernel: Bad page state at free_hot_cold_page (in
> process 'xmms', page c12da9c0)
> Dec  9 16:53:20 slawek kernel: flags:0x80000414 mapping:00000000 mapcount:0
> count:0

I think that means you have a mismatch: that you're using core/memalloc.c
from alsa-driver-1.0.10/alsa-kernel rather than from 2.6.15-rc5/sound.
Applying the update below should eliminate your "Bad page state"s:
I've no idea whether there are other mismatches, quite possibly not.

Hugh

--- alsa-driver-1.0.10/alsa-kernel/core/memalloc.c	2005-10-31 13:11:53.000000000 +0000
+++ 2.6.15-rc5/sound/core/memalloc.c	2005-12-04 06:48:20.000000000 +0000
@@ -197,6 +197,7 @@ void *snd_malloc_pages(size_t size, gfp_
 
 	snd_assert(size > 0, return NULL);
 	snd_assert(gfp_flags != 0, return NULL);
+	gfp_flags |= __GFP_COMP;	/* compound page lets parts be mapped */
 	pg = get_order(size);
 	if ((res = (void *) __get_free_pages(gfp_flags, pg)) != NULL) {
 		mark_pages(virt_to_page(res), pg);
@@ -241,6 +242,7 @@ static void *snd_malloc_dev_pages(struct
 	snd_assert(dma != NULL, return NULL);
 	pg = get_order(size);
 	gfp_flags = GFP_KERNEL
+		| __GFP_COMP	/* compound page lets parts be mapped */
 		| __GFP_NORETRY /* don't trigger OOM-killer */
 		| __GFP_NOWARN; /* no stack trace print - this call is non-critical */
 	res = dma_alloc_coherent(dev, PAGE_SIZE << pg, dma, gfp_flags);

  reply	other threads:[~2005-12-09 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-09 16:32 Jacek Luczak
2005-12-09 16:14 ` Hugh Dickins [this message]
2005-12-09 16:51   ` Jacek Luczak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0512091610160.24942@goblin.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=difrost@pin.if.uz.zgora.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®