mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Brice Goglin <Brice.Goglin@ens-lyon.org>
Cc: Martin Drab <drab@kepler.fjfi.cvut.cz>,
	Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.15-rc5 bad page with fglrx on Radeon X300
Date: Sun, 11 Dec 2005 10:49:24 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.61.0512111038510.3858@goblin.wat.veritas.com> (raw)
In-Reply-To: <439B475F.2050901@ens-lyon.org>

On Sat, 10 Dec 2005, Brice Goglin wrote:
> Does anybody out there have ATI drivers working on Radeon X300
> on 2.6.15-rc5 (or -rc[234]) ? They released fglrx 8.20.8 on december 8th.
> I thought they would have fixed the driver for 2.6.15.
> But, I still get bad page and X programs freezing.

The ATI wrapper source is carefully "#if 0"ing a get_page because of the
traditional anomalous behaviour of PageReserved.  2.6.15-rc killed that
anomalous behaviour, so their "#if 0" needs to become a version test.

Big thanks to Martin Drab for testing this (and correcting the stupidity
of my original inverted patch) - tell us if it does not work for you too.

Hugh

--- fglrx.orig/build_mod/firegl_public.c	2005-12-05 15:47:41.000000000 +0000
+++ fglrx/build_mod/firegl_public.c	2005-12-05 17:18:12.000000000 +0000
@@ -2586,7 +2586,7 @@ static __inline__ vm_nopage_ret_t do_vm_
 
     pMmPage = virt_to_page(kaddr);
 
-#if 0
+#if LINUX_VERSION_CODE >= 0x02060f
     // WARNING WARNINIG WARNNING WARNNING WARNNING WARNNING WARNNING WARNNING
     // Don't increment page usage count, cause ctx pages are allocated
     // with drm_alloc_pages, which marks all pages as reserved. Reserved

  parent reply	other threads:[~2005-12-11 10:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-04  6:03 Linux 2.6.15-rc5: off-line for a week Linus Torvalds
2005-12-04 15:34 ` Gene Heskett
2005-12-04 18:50   ` Michael Krufky
2005-12-04 20:47     ` Gene Heskett
2005-12-04 21:14       ` Michael Krufky
2005-12-05  0:16         ` Gene Heskett
2005-12-04 16:56 ` Jesper Juhl
2005-12-04 17:26   ` Michal Piotrowski
2005-12-04 18:35     ` Jesper Juhl
2005-12-04 22:25       ` Andrea Arcangeli
2005-12-04 23:43 ` Linux 2.6.15-rc5: sk98lin broken Johannes Stezenbach
2005-12-05 19:00   ` [PATCH linux-2.6.15-rc5] sk98lin: rx checksum offset not set Stephen Hemminger
2005-12-05 19:22     ` Johannes Stezenbach
2005-12-05 19:13   ` Linux 2.6.15-rc5: sk98lin broken Bill Davidsen
2005-12-07 21:59 ` Linux 2.6.15-rc5: off-line for a week Rich Walker
2005-12-10 16:27 ` Linux 2.6.15-rc5: multiuser scheduling trouble Helge Hafting
2005-12-12  0:09   ` Linus Torvalds
2005-12-12  6:51     ` Ingo Molnar
2005-12-12 11:18       ` Helge Hafting
2005-12-12 11:30       ` Nix
2005-12-12 12:31         ` Helge Hafting
2005-12-12 10:51     ` Helge Hafting
2005-12-10 21:23 ` Linux 2.6.15-rc5 bad page with fglrx on Radeon X300 Brice Goglin
2005-12-10 21:43   ` Lee Revell
2005-12-11 10:49   ` Hugh Dickins [this message]
     [not found] <5fVeA-714-27@gated-at.bofh.it>
     [not found] ` <5iksa-2mf-3@gated-at.bofh.it>
2005-12-10 21:46   ` ldonesty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0512111038510.3858@goblin.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=Brice.Goglin@ens-lyon.org \
    --cc=drab@kepler.fjfi.cvut.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®