From: Hugh Dickins <hugh@veritas.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: pte_alloc_kernel parameters
Date: Fri, 16 Dec 2005 21:05:57 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.61.0512162057190.8996@goblin.wat.veritas.com> (raw)
In-Reply-To: <43A19190.76F0.0078.0@novell.com>
On Thu, 15 Dec 2005, Jan Beulich wrote:
> Is there any particular reason why pte_alloc_kernel() has to have
> 'struct mm_struct*' as its first parameter? Except for a case in parisc
> (where NULL gets passed) and another (ill-looking one) in arm26 it is
> always &init_mm, and since the function is not inline the compiler can't
> eliminate the needless passing of the argument.
You're looking at old source: it's gone in 2.6.15-rc. There was a point
to it before 2.6.13 - arch/ppc64 used it on its ioremap_mm too, but has
since amalgamated that into init_mm. I removed the arg in 2.6.15-rc,
not really as an optimization, more to force a build error on mismatch
when making a change to the locking there.
Hugh
prev parent reply other threads:[~2005-12-16 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 14:53 Jan Beulich
2005-12-16 21:05 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0512162057190.8996@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=JBeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®