From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750794AbWBFIpn (ORCPT ); Mon, 6 Feb 2006 03:45:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750797AbWBFIpm (ORCPT ); Mon, 6 Feb 2006 03:45:42 -0500 Received: from gold.veritas.com ([143.127.12.110]:61260 "EHLO gold.veritas.com") by vger.kernel.org with ESMTP id S1750794AbWBFIpm (ORCPT ); Mon, 6 Feb 2006 03:45:42 -0500 Date: Mon, 6 Feb 2006 08:46:07 +0000 (GMT) From: Hugh Dickins X-X-Sender: hugh@goblin.wat.veritas.com To: Pete Zaitcev cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] stop ==== emergency In-Reply-To: <20060205205709.0b88171b.zaitcev@redhat.com> Message-ID: References: <20060205205709.0b88171b.zaitcev@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 06 Feb 2006 08:45:35.0707 (UTC) FILETIME=[B28742B0:01C62AF9] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 5 Feb 2006, Pete Zaitcev wrote: > On Fri, 3 Feb 2006 21:37:09 +0000 (GMT), Hugh Dickins wrote: > > > +++ linux/arch/i386/kernel/traps.c 2006-02-03 09:59:37.000000000 +0000 > > @@ -166,7 +166,8 @@ static void show_trace_log_lvl(struct ta > > stack = (unsigned long*)context->previous_esp; > > if (!stack) > > break; > > - printk(KERN_EMERG " =======================\n"); > > + printk(log_lvl); > > + printk(" =======================\n"); > > } > > This is wrong, Hugh. What do you think the priority of the second printk? > It's not log_lvl, that's for sure. Are you sure? I've not delved into the printk code itself, but this does follow the same pattern as in show_stack_log_lvl itself e.g. its "Call Trace:\n" line. (I am assuming print_context_stack ends with a newline, as it does.) Hugh