mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Roland Dreier <rolandd@cisco.com>
Cc: Kai Makisara <Kai.Makisara@kolumbus.fi>,
	Willem Riede <osst@riede.org>,
	linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [git patch review 2/2] IB: Don't doublefree pages from scatterlist
Date: Mon, 6 Feb 2006 22:29:59 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.61.0602062221200.3844@goblin.wat.veritas.com> (raw)
In-Reply-To: <1139070837112-3fe13a3288c20f5c@cisco.com>

On Sat, 4 Feb 2006, Roland Dreier wrote:

> On some architectures, mapping the scatterlist may coalesce entries:
> if that coalesced list is then used for freeing the pages afterwards,
> there's a danger that pages may be doubly freed (and others leaked).
> 
> Fix Infiniband's __ib_umem_release by freeing from a separate array
> beyond the scatterlist: IB_UMEM_MAX_PAGE_CHUNK lowered to fit one page.

It's now looking like this change won't be needed after all: Andi has
just posted a patch in the "ipr" thread which should stop x86_64 from
interfering with the scatterlist *page,offset,length fields, so what
IB and others were doing should then work safely (current thinking is
that x86_64 is the only architecture which coalesced in that way).

Hugh

  reply	other threads:[~2006-02-06 22:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-04 16:33 [git patch review 1/2] IB/mad: Handle DR SMPs with a LID routed part Roland Dreier
2006-02-04 16:33 ` [git patch review 2/2] IB: Don't doublefree pages from scatterlist Roland Dreier
2006-02-06 22:29   ` Hugh Dickins [this message]
2006-02-07  1:44     ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0602062221200.3844@goblin.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=Kai.Makisara@kolumbus.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openib-general@openib.org \
    --cc=osst@riede.org \
    --cc=rolandd@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®