mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesper Juhl <juhl-lkml@dif.dk>
To: Steve French <smfrench@austin.rr.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][0/6] cifs: readdir.c cleanup
Date: Tue, 22 Mar 2005 22:50:08 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.62.0503222244380.2683@dragon.hyggekrogen.localhost> (raw)
In-Reply-To: <42408FCD.1080303@austin.rr.com>

On Tue, 22 Mar 2005, Steve French wrote:

> Jesper Juhl wrote:
> 
> > Hi Steve,
> > 
> > Here's one more cleanup for a file in fs/cifs - readdir.c (i'm going to
> > follow the order you told me you'd prefer first, then do the remaining files
> > in arbitrary order).
> > I'm going to send the patches inline to make it easy for others to comment
> > if they so choose, but since you had problems with inline patches from me
> > last time I've also placed them online for you :
> > 
[snip]
> >  
> The first looks fine.  I am part way through reviewing the second, and so far
> only found one change (see following) that I question.  I prefer to keep the
> local variables together without a blank line between them.  Is there a global
> Linux style compliance issue here?  By the way, it is not common to use
> typedefs but you will see a few in this function since the network protocol
> specification describes the format of the wire protocol using them and it
> makes the structure names match the standard.
> 
> static char *nxt_dir_entry(char *old_entry, char *end_of_smb)
> {
> -	char * new_entry;
> -	FILE_DIRECTORY_INFO * pDirInfo = (FILE_DIRECTORY_INFO *)old_entry;
> +	char *new_entry;
> +
> +	FILE_DIRECTORY_INFO *pDirInfo = (FILE_DIRECTORY_INFO *)old_entry;
> 
Actually, this is me goofing up. I did intend for all local variables to 
be grouped without a single blank line between them - just one blank line 
*after* the variable block - don't know how this bit snuck in. Thank you 
for catching that.


> I will apply at least a few of them, but I am busy doing a high priority fix
> to handle split transact2 responses (which could cause an oops in ls to some
> servers so is high priority - although it only occurs on large directories,
> and if the server decides to send two transact responses for one request
> (which is not that common) and a search entry is split in certain ways across
> two SMB responses).
> 
I'm fully aware that these patches are low-priority. I don't expect them 
to get anything but "at my convenience" treatment from you.
And should you miss some of them (I'll be sending you quite a few over the 
next few days I expect) I'll just queue them locally and resend at some 
later date (post next Linus release or so), so don't feel pressured to 
look at these if you don't have the time.


-- 
Jesper



      reply	other threads:[~2005-03-22 21:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-22 20:04 Jesper Juhl
2005-03-22 21:36 ` Steve French
2005-03-22 21:50   ` Jesper Juhl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.62.0503222244380.2683@dragon.hyggekrogen.localhost \
    --to=juhl-lkml@dif.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=smfrench@austin.rr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®