From: Jesper Juhl <juhl-lkml@dif.dk>
To: Maciej Soltysiak <solt2@dns.toxicfilms.tv>
Cc: "James P. Ketrenos" <ipw2100-admin@linux.intel.com>,
netdev@oss.sgi.com, "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [2.6.12-rc1-mm4] swapped memset arguments
Date: Sun, 3 Apr 2005 00:38:54 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.62.0504030035190.2525@dragon.hyggekrogen.localhost> (raw)
In-Reply-To: <74334709.20050402233007@dns.toxicfilms.tv>
On Sat, 2 Apr 2005, Maciej Soltysiak wrote:
> Hi,
>
> out of boredom I grepped 2.6.12-rc1-mm4 for swapped memset arguments.
> I found one:
>
> # grep -nr "memset.*\,\(\ \|\)0\(\ \|\));" *
> net/ieee80211/ieee80211_tx.c:226: memset(txb, sizeof(struct ieee80211_txb), 0);
>
And here's a patch :
Fix swapped memset() arguments in net/ieee80211/ieee80211_tx.c
found by Maciej Soltysiak.
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
--- linux-2.6.12-rc1-mm4-orig/net/ieee80211/ieee80211_tx.c 2005-03-31 21:20:08.000000000 +0200
+++ linux-2.6.12-rc1-mm4/net/ieee80211/ieee80211_tx.c 2005-04-03 00:34:22.000000000 +0200
@@ -223,7 +223,7 @@ struct ieee80211_txb *ieee80211_alloc_tx
if (!txb)
return NULL;
- memset(txb, sizeof(struct ieee80211_txb), 0);
+ memset(txb, 0, sizeof(struct ieee80211_txb));
txb->nr_frags = nr_frags;
txb->frag_size = txb_size;
next prev parent reply other threads:[~2005-04-02 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-02 21:30 Maciej Soltysiak
2005-04-02 22:38 ` Jesper Juhl [this message]
2005-04-05 15:37 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0504030035190.2525@dragon.hyggekrogen.localhost \
--to=juhl-lkml@dif.dk \
--cc=davem@davemloft.net \
--cc=ipw2100-admin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=solt2@dns.toxicfilms.tv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®