mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesper Juhl <juhl-lkml@dif.dk>
To: David Teigland <teigland@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 2/7] dlm: communication
Date: Mon, 25 Apr 2005 20:10:04 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.62.0504251844540.2941@dragon.hyggekrogen.localhost> (raw)
In-Reply-To: <20050425151218.GC6826@redhat.com>

On Mon, 25 Apr 2005, David Teigland wrote:

> 
> Inter-node communiction using SCTP.  This level is not aware of locks or
> resources or other dlm objects, only data buffers.  These functions also
> batch (and extract) lots of small messages bound for one node into larger
> chunks.
> 
> Signed-Off-By: Dave Teigland <teigland@redhat.com>
> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
> 
> ---
> 
> +struct connection {
> +	struct socket *		sock;
> +	unsigned long		flags;
> +	struct page *		rx_page;
> +	atomic_t		waiting_requests;
> +	struct cbuf		cb;
> +};

type * varname;  is not very pretty. The prefered form is generally
type *varname;
Several instances of this in various places.


> +static void init_failed(void)
> +{
> +	int i;
> +	struct nodeinfo *ni;
> +
> +	for (i=1; i<=max_nodeid; i++) {
Nitpicking, but how about a few spaces? 
        for (i = 1; i <= max_nodeid; i++) {
makes it more readable IMHO.

> +#if 0
> +static int lowcomms_close(int nodeid)
> +{

Ehh, why try and merge code that's not active? Why not leave it out and 
submit a patch later to add it if it is needed later?


-- 
Jesper Juhl



      reply	other threads:[~2005-04-25 18:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-25 15:12 David Teigland
2005-04-25 18:10 ` Jesper Juhl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.62.0504251844540.2941@dragon.hyggekrogen.localhost \
    --to=juhl-lkml@dif.dk \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=teigland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®