From: Jesper Juhl <juhl-lkml@dif.dk>
To: Robert Love <rml@novell.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
kpreempt-tech@lists.sourceforge.net
Subject: Re: preempt-count oddities - still looking for comments :)
Date: Tue, 26 Apr 2005 22:05:11 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.62.0504262159330.2071@dragon.hyggekrogen.localhost> (raw)
In-Reply-To: <1114537590.6851.3.camel@betsy>
On Tue, 26 Apr 2005, Robert Love wrote:
> On Tue, 2005-04-26 at 19:46 +0200, Jesper Juhl wrote:
>
> > I'll update the patch(es) then and use __s32 in the structure and s32
> > elsewhere.
>
> You can actually use s32 everywhere, since the structure is never
> exported to user-space...although some architectures already have the
> __ugly versions in there.
>
Hmm, one downside to using "s32" instead of plain "int" is that not all
thread_info.h files get asm/types.h pulled in and then won't have that
type defined (m68knommu is one such as far as I can see). Would this make
"int" prefered after all or should I just include asm/types.h where needed
or just include it everywhere? seems logical that the file that uses
header includes it directly instead of it getting included implicitly by
other headers (like i386 where thread_info.h includes asm/page.h that then
includes asm/mmx.h that then includes linux/types.h that finally includes
asm/types.h).
Personally I'd just add the asm/types.h include to all the thread_info.h
files (or go back to using int) - what's your preference?
--
Jesper
next prev parent reply other threads:[~2005-04-26 20:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-23 21:30 preempt-count oddities Jesper Juhl
2005-04-26 17:31 ` preempt-count oddities - still looking for comments :) Jesper Juhl
2005-04-26 17:35 ` Robert Love
2005-04-26 17:46 ` Jesper Juhl
2005-04-26 17:46 ` Robert Love
2005-04-26 17:57 ` Jesper Juhl
2005-04-26 20:05 ` Jesper Juhl [this message]
2005-04-26 20:28 ` Robert Love
2005-04-26 20:55 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0504262159330.2071@dragon.hyggekrogen.localhost \
--to=juhl-lkml@dif.dk \
--cc=kpreempt-tech@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®