mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesper Juhl <juhl-lkml@dif.dk>
To: acme@ghostprotocols.net
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Jouni Malinen <jkmaline@cc.hut.fi>,
	James Morris <jmorris@intercode.com.au>,
	Pedro Roque <roque@di.fc.ul.pt>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Kunihiro Ishiguro <kunihiro@ipinfusion.com>,
	Mitsuru KANDA <mk@linux-ipv6.org>,
	lksctp-developers@lists.sourceforge.net,
	Andy Adamson <andros@umich.edu>, Bruce Fields <bfields@umich.edu>,
	netdev@oss.sgi.com, linux-net@vger.kernel.org,
	linux-kernel@vger.kernel.org, juhl-lkml@dif.dk
Subject: [PATCH 0/4] resource release cleanup in net/ (take 2)
Date: Sun, 1 May 2005 03:46:10 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.62.0505010341560.2094@dragon.hyggekrogen.localhost> (raw)
In-Reply-To: <39e6f6c705043014264eb4c0c5@mail.gmail.com>

On Sat, 30 Apr 2005, Arnaldo Carvalho de Melo wrote:

> On 4/30/05, Jesper Juhl <juhl-lkml@dif.dk> wrote:
> > Hi David,
> > 
> > Since Andrew merged the patch that makes calling crypto_free_tfm() with a
> > NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for
> > NULL before calling that function, and while I was at it I removed similar
> > redundant checks before calls to kfree() and vfree() in the same files.
> > There are also a few tiny whitespace cleanups in there.
> 
> Jesper, I'd suggest that you left whitespaces for a separate patch, it
> is always,
> IMHO, better to have as small a patch as possible for reviewing.
> 
Sure thing. I've split the patches, and I believe that me going through 
them a second time did them good, there are a few tiny changes over the 
first version.

I split the patch in 4 parts (will send as replies to this mail) : 
	1) crypto_free_tfm related changes
	2) kfree related changes
	3) vfree related changes
	4) whitespace changes
The whitespace changes ended up fairly bigger than initially. I expanded 
the cleanup a bit. It's not a perfect, 100% complete cleanup, but it's IMO 
a lot better than the originals.

-- 
Jesper



  reply	other threads:[~2005-05-01  1:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-30 20:36 [PATCH] resource release cleanup in net/ Jesper Juhl
2005-04-30 21:26 ` Arnaldo Carvalho de Melo
2005-05-01  1:46   ` Jesper Juhl [this message]
2005-05-01  1:48     ` [PATCH 1/4] resource release cleanup in net/ (take 2) Jesper Juhl
2005-05-01  1:50     ` [PATCH 2/4] " Jesper Juhl
2005-05-01  1:52     ` [PATCH 3/4] " Jesper Juhl
2005-05-01  1:55     ` [PATCH 4/4] " Jesper Juhl
2005-05-01  2:09       ` YOSHIFUJI Hideaki / 吉藤英明
2005-05-01  2:53 ` [PATCH] resource release cleanup in net/ Alexey Dobriyan
2005-04-30 23:13   ` Jesper Juhl
2005-05-01 12:32     ` Alexey Dobriyan
2005-05-01 23:08 ` Herbert Xu
2005-05-01 23:21   ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.62.0505010341560.2094@dragon.hyggekrogen.localhost \
    --to=juhl-lkml@dif.dk \
    --cc=acme@ghostprotocols.net \
    --cc=andros@umich.edu \
    --cc=arnaldo.melo@gmail.com \
    --cc=bfields@umich.edu \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jkmaline@cc.hut.fi \
    --cc=jmorris@intercode.com.au \
    --cc=kunihiro@ipinfusion.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=lksctp-developers@lists.sourceforge.net \
    --cc=mk@linux-ipv6.org \
    --cc=netdev@oss.sgi.com \
    --cc=roque@di.fc.ul.pt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®