From: Kylene Hall <kjhall@us.ibm.com>
To: akpm@osdl.org
Cc: jgarzik@pobox.com, greg@kroah.com, linux-kernel@vger.kernel.org
Subject: [PATCH: 2 of 12 ] Fix TPM driver -- address missing const defs
Date: Thu, 5 May 2005 14:09:56 -0500 (CDT) [thread overview]
Message-ID: <Pine.LNX.4.62.0505051324010.5303@localhost.localdomain> (raw)
Please apply these fixes to the Tpm driver. I am resubmitting the entire
patch set that was orginally sent to LKML on April 27 with the changes
that were requested fixed.
Thanks,
Kylie
On Wed, 9 Mar 2005, Jeff Garzik wrote:
> Greg KH wrote:
<snip>
> > +static u8 cap_pcr[] = {
> > + 0, 193, /* TPM_TAG_RQU_COMMAND */
> > + 0, 0, 0, 22, /* length */
> > + 0, 0, 0, 101, /* TPM_ORD_GetCapability */
> > + 0, 0, 0, 5,
> > + 0, 0, 0, 4,
> > + 0, 0, 1, 1
> > +};
>
> const
>
>
> > +#define READ_PCR_RESULT_SIZE 30
> > +static u8 pcrread[] = {
> > + 0, 193, /* TPM_TAG_RQU_COMMAND */
> > + 0, 0, 0, 14, /* length */
> > + 0, 0, 0, 21, /* TPM_ORD_PcrRead */
> > + 0, 0, 0, 0 /* PCR index */
> > +};
>
> const
<snip>
> > +static u8 cap_version[] = {
> > + 0, 193, /* TPM_TAG_RQU_COMMAND */
> > + 0, 0, 0, 18, /* length */
> > + 0, 0, 0, 101, /* TPM_ORD_GetCapability */
> > + 0, 0, 0, 6,
> > + 0, 0, 0, 0
> > +};
>
> const
>
>
> > +#define CAP_MANUFACTURER_RESULT_SIZE 18
> > +static u8 cap_manufacturer[] = {
> > + 0, 193, /* TPM_TAG_RQU_COMMAND */
> > + 0, 0, 0, 22, /* length */
> > + 0, 0, 0, 101, /* TPM_ORD_GetCapability */
> > + 0, 0, 0, 5,
> > + 0, 0, 0, 4,
> > + 0, 0, 1, 3
> > +};
>
> const
>
<snip>
> > +static u8 savestate[] = {
> > + 0, 193, /* TPM_TAG_RQU_COMMAND */
> > + 0, 0, 0, 10, /* blob length (in bytes) */
> > + 0, 0, 0, 152 /* TPM_ORD_SaveState */
> > +};
>
> const
<snip>
The following patch addresses the need for all of this missing const
definitions.
Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
---
diff -uprN --exclude='*.orig' linux-2.6.12-rc2/drivers/char/tpm/tpm.c linux-2.6.12-rc2-tpmdd/drivers/char/tpm/tpm.c
--- linux-2.6.12-rc2/drivers/char/tpm/tpm.c 2005-04-18 18:40:07.000000000 -0500
+++ linux-2.6.12-rc2-tpmdd/drivers/char/tpm/tpm.c 2005-04-20 17:11:43.000000000 -0500
@@ -192,7 +192,7 @@ out_recv:
#define TPM_DIGEST_SIZE 20
#define CAP_PCR_RESULT_SIZE 18
-static u8 cap_pcr[] = {
+static const u8 cap_pcr[] = {
0, 193, /* TPM_TAG_RQU_COMMAND */
0, 0, 0, 22, /* length */
0, 0, 0, 101, /* TPM_ORD_GetCapability */
@@ -202,7 +202,7 @@ static u8 cap_pcr[] = {
};
#define READ_PCR_RESULT_SIZE 30
-static u8 pcrread[] = {
+static const u8 pcrread[] = {
0, 193, /* TPM_TAG_RQU_COMMAND */
0, 0, 0, 14, /* length */
0, 0, 0, 21, /* TPM_ORD_PcrRead */
@@ -246,7 +246,7 @@ static ssize_t show_pcrs(struct device *
static DEVICE_ATTR(pcrs, S_IRUGO, show_pcrs, NULL);
#define READ_PUBEK_RESULT_SIZE 314
-static u8 readpubek[] = {
+static const u8 readpubek[] = {
0, 193, /* TPM_TAG_RQU_COMMAND */
0, 0, 0, 30, /* length */
0, 0, 0, 124, /* TPM_ORD_ReadPubek */
@@ -309,7 +309,7 @@ static ssize_t show_pubek(struct device
static DEVICE_ATTR(pubek, S_IRUGO, show_pubek, NULL);
#define CAP_VER_RESULT_SIZE 18
-static u8 cap_version[] = {
+static const u8 cap_version[] = {
0, 193, /* TPM_TAG_RQU_COMMAND */
0, 0, 0, 18, /* length */
0, 0, 0, 101, /* TPM_ORD_GetCapability */
@@ -318,7 +318,7 @@ static u8 cap_version[] = {
};
#define CAP_MANUFACTURER_RESULT_SIZE 18
-static u8 cap_manufacturer[] = {
+static const u8 cap_manufacturer[] = {
0, 193, /* TPM_TAG_RQU_COMMAND */
0, 0, 0, 22, /* length */
0, 0, 0, 101, /* TPM_ORD_GetCapability */
next reply other threads:[~2005-05-05 19:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-05 19:09 Kylene Hall [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-10 0:42 [PATCH] Add TPM hardware enablement driver Greg KH
2005-03-10 3:51 ` Jeff Garzik
2005-04-27 22:15 ` [PATCH: 2 of 12 ] Fix TPM driver -- address missing const defs Kylene Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0505051324010.5303@localhost.localdomain \
--to=kjhall@us.ibm.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®