mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesper Juhl <juhl-lkml@dif.dk>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: [PATCH] kernel/module.c has something to hide. (whitespace cleanup)
Date: Wed, 11 May 2005 01:02:16 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.62.0505110057500.2386@dragon.hyggekrogen.localhost> (raw)


Quoting Documentation/CodingStyle : 
        "Don't put multiple statements on a single line unless you have
         something to hide:
         
         if (condition) do_this;
           do_something_everytime;
        "

Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
---

 kernel/module.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

--- linux-2.6.12-rc3-mm3-orig/kernel/module.c	2005-05-06 23:21:28.000000000 +0200
+++ linux-2.6.12-rc3-mm3/kernel/module.c	2005-05-11 00:56:54.000000000 +0200
@@ -410,7 +410,8 @@ static int already_uses(struct module *a
 static int use_module(struct module *a, struct module *b)
 {
 	struct module_use *use;
-	if (b == NULL || already_uses(a, b)) return 1;
+	if (b == NULL || already_uses(a, b))
+		return 1;
 
 	if (!strong_try_module_get(b))
 		return 0;
@@ -1731,9 +1732,10 @@ static struct module *load_module(void _
 	kfree(args);
  free_hdr:
 	vfree(hdr);
-	if (err < 0) return ERR_PTR(err);
-	else return ptr;
-
+	if (err < 0)
+		return ERR_PTR(err);
+	else
+		return ptr;
  truncated:
 	printk(KERN_ERR "Module len %lu truncated\n", len);
 	err = -ENOEXEC;




             reply	other threads:[~2005-05-10 22:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-10 23:02 Jesper Juhl [this message]
2005-05-10 23:16 ` Andrew Morton
2005-05-10 23:30   ` Jesper Juhl
     [not found]   ` <20050510.161907.116353193.davem@davemloft.net>
2005-05-11  0:02     ` Andrew Morton
2005-05-11  0:11       ` Jesper Juhl
2005-05-11  0:23         ` Andrew Morton
     [not found]       ` <20050510.170946.10291902.davem@davemloft.net>
2005-05-11  0:28         ` Jesper Juhl
2005-05-11  0:29           ` Andrew Morton
2005-05-11  0:38             ` Jesper Juhl
2005-05-11 11:07               ` Paulo Marques
2005-05-11 22:56                 ` Adrian Bunk
2005-05-12 12:16                   ` Paulo Marques
2005-05-12 13:36                     ` Paulo Marques
2005-05-12 17:26                       ` Jesper Juhl
2005-05-12 18:06                         ` Hugh Dickins
2005-05-11  1:01             ` Tom Duffy
2005-05-11  9:04               ` Adrian Bunk
     [not found] <42Mbg-Tq-25@gated-at.bofh.it>
     [not found] ` <42MXA-1zI-3@gated-at.bofh.it>
     [not found]   ` <42MXA-1zI-1@gated-at.bofh.it>
     [not found]     ` <42Nh3-1M8-17@gated-at.bofh.it>
     [not found]       ` <42Nh3-1M8-15@gated-at.bofh.it>
2005-05-11 23:47         ` Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org>
2005-05-12  4:00           ` Nick Piggin
2005-05-12  5:16             ` Bodo Eggert
2005-05-12  8:41           ` Jesper Juhl
2005-05-12  8:47             ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.62.0505110057500.2386@dragon.hyggekrogen.localhost \
    --to=juhl-lkml@dif.dk \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®