Re: [PATCH] tpm: improve output in sysfs files when the TPM fails

[Kylene Hall <kjhall@us.ibm.com>]

On Fri, 13 May 2005, Andrew Morton wrote:

> Kylene Hall <kjhall@us.ibm.com> wrote:
> >
> >  On Thu, 12 May 2005, Greg KH wrote:
> >  > On Thu, May 12, 2005 at 05:20:22PM -0500, Kylene Hall wrote:
> >  > > When the TPM is in a disabled or deactivated state the sysfs pcrs and 
> >  > > pubek files will appear empty.  To remove any confusion this might cause, 
> >  > > the files will instead contain the error the TPM returned (also indicative 
> >  > > of what state the TPM is in and what actions might be needed to change 
> >  > > that state).
> >  > 
> >  > No, sysfs files are not error logs.  Please use the standard system wide
> >  > error log for this (syslog).
> >  > 
> >  > Why not just change the mode of the sysfs file instead, or delete it
> >  > entirely in this case?
> > 
> >  Ok, instead of putting error information in the sysfs file this new patch 
> >  will put an error entry in syslog.  The sysfs files can't easily be 
> >  removed in these cases as the driver does not know this information and it 
> >  can be changed by commands sent to the TPM from userspace.
> 
> Will this change permit unprivileged users to create large amounts of
> syslog output?  If so, this is considered poor form.
> 
> IOW: please confirm that the relevant sysfs files are root-read-only?
> 
> 

Please back this patch out since it is undesirable to use the sysfs 
file or syslog for the error reporting for various reasons and is 
desirable to keep the files not root-read-only.  The status of the TPM can 
be gleaned from other sources.

Thanks,
Kylie