From: Jesper Juhl <juhl-lkml@dif.dk>
To: "James E.J. Bottomley" <James.Bottomley@SteelEye.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Eric Youngdale <eric@andante.org>,
linux-scsi@vger.kernel.org
Subject: Re: test of 'good_bytes' in scsi_io_completion is always true (in drivers/scsi/scsi_lib.c)
Date: Mon, 16 May 2005 18:55:41 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.62.0505161852550.3101@dragon.hyggekrogen.localhost> (raw)
In-Reply-To: <Pine.LNX.4.62.0504200030180.2074@dragon.hyggekrogen.localhost>
(please keep me on the CC list when replying)
Hi James,
I never got any response to the mail below, so I'll try again :)
Should we just get rid of the code in the 'if' since it'll never trigger,
or was the intention actually to test if (good_bytes > 0) ? If so, then
the patch should make good sense...
Comments ?
--
Jesper Juhl
On Wed, 20 Apr 2005, Jesper Juhl wrote:
>
> in drivers/scsi/scsi_lib.c::scsi_io_completion() 'good_bytes' is tested
> for being >= 0, but 'good_bytes' is an unsigned int, so that test is
> always true. My *guess* is that what was intended was to test if
> good_bytes is > 0, but I don't know this code well enough to be sure.
> The patch below makes the change to test if it's > 0, but if the code in
> the 'if' really wants to run if it's >= 0, then we might as well just
> remove the 'if'.
>
> In any case, the current code looks fishy.
>
>
> Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
>
> --- linux-2.6.12-rc2-mm3-orig/drivers/scsi/scsi_lib.c 2005-04-11 21:20:49.000000000 +0200
> +++ linux-2.6.12-rc2-mm3/drivers/scsi/scsi_lib.c 2005-04-20 00:29:14.000000000 +0200
> @@ -766,7 +766,7 @@ void scsi_io_completion(struct scsi_cmnd
> * Next deal with any sectors which we were able to correctly
> * handle.
> */
> - if (good_bytes >= 0) {
> + if (good_bytes > 0) {
> SCSI_LOG_HLCOMPLETE(1, printk("%ld sectors total, %d bytes done.\n",
> req->nr_sectors, good_bytes));
> SCSI_LOG_HLCOMPLETE(1, printk("use_sg is %d\n", cmd->use_sg));
>
>
>
>
> Please keep me on CC:
>
next prev parent reply other threads:[~2005-05-16 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 22:38 Jesper Juhl
2005-05-16 16:55 ` Jesper Juhl [this message]
2005-05-16 17:03 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0505161852550.3101@dragon.hyggekrogen.localhost \
--to=juhl-lkml@dif.dk \
--cc=James.Bottomley@SteelEye.com \
--cc=eric@andante.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®