From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261507AbVF1OG4 (ORCPT ); Tue, 28 Jun 2005 10:06:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261578AbVF1OEb (ORCPT ); Tue, 28 Jun 2005 10:04:31 -0400 Received: from graphe.net ([209.204.138.32]:22478 "EHLO graphe.net") by vger.kernel.org with ESMTP id S261675AbVF1OCn (ORCPT ); Tue, 28 Jun 2005 10:02:43 -0400 Date: Tue, 28 Jun 2005 07:02:26 -0700 (PDT) From: Christoph Lameter X-X-Sender: christoph@graphe.net To: Kirill Korotaev cc: Pavel Machek , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org, raybry@engr.sgi.com, Alexey Kuznetsov Subject: Re: [RFC] Fix SMP brokenness for PF_FREEZE and make freezing usable for other purposes In-Reply-To: <42C10690.10108@sw.ru> Message-ID: References: <20050625025122.GC22393@atrey.karlin.mff.cuni.cz> <20050626023053.GA2871@atrey.karlin.mff.cuni.cz> <20050626030925.GA4156@atrey.karlin.mff.cuni.cz> <20050627141320.GA4945@atrey.karlin.mff.cuni.cz> <42C0EBAB.8070709@sw.ru> <42C0FCB3.4030205@sw.ru> <42C10690.10108@sw.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Score: -5.9 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jun 2005, Kirill Korotaev wrote: > Christoph I was wrong a bit. Due to use of completion you have no one race I > described before. If the task is leaving refrigarator with TIF_FREEZE it will > just visit refrigarator() once more, but won't sleep there since completion > is done. BTW, I see no place where you initialize the completion. It is initialized through the DECLARE_COMPLETION in sched.c.