From: Christoph Lameter <christoph@lameter.com>
To: Pekka J Enberg <penberg@cs.Helsinki.FI>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, manfred@colorfullife.com
Subject: Re: [PATCH] slab: minor cleanup to kmem_cache_alloc_node
Date: Mon, 21 Nov 2005 09:21:32 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.62.0511210919001.6497@graphe.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0511211627460.18869@sbz-30.cs.Helsinki.FI>
On Mon, 21 Nov 2005, Pekka J Enberg wrote:
> This patch gets rid of one if-else statement by moving current node allocation
> check at the beginning of kmem_cache_alloc_node().
The problem with this is that the numa_node may change if irqs are still
active and your patch moves the check for the numa node outside of the
section where irqs are enabled.
You could move the check for -1 into the section where interrupts are
disabled.
next prev parent reply other threads:[~2005-11-21 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 14:30 Pekka J Enberg
2005-11-21 15:58 ` Eric Dumazet
2005-11-21 16:23 ` Pekka Enberg
2005-11-21 17:21 ` Christoph Lameter [this message]
2005-11-21 18:36 ` Pekka Enberg
2005-11-21 19:47 ` Christoph Lameter
2005-11-21 21:07 ` Pekka Enberg
2005-11-21 21:17 ` Christoph Lameter
2005-11-22 6:57 ` Pekka J Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0511210919001.6497@graphe.net \
--to=christoph@lameter.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=penberg@cs.Helsinki.FI \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®