From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422700AbWATAFp (ORCPT ); Thu, 19 Jan 2006 19:05:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422701AbWATAFp (ORCPT ); Thu, 19 Jan 2006 19:05:45 -0500 Received: from omx3-ext.sgi.com ([192.48.171.26]:43698 "EHLO omx3.sgi.com") by vger.kernel.org with ESMTP id S1422700AbWATAFo (ORCPT ); Thu, 19 Jan 2006 19:05:44 -0500 Date: Thu, 19 Jan 2006 16:05:27 -0800 (PST) From: Christoph Lameter To: akpm@osdl.org cc: linux-kernel@vger.kernel.org Subject: [PATCH] shrink_list: Use of && instead || leads to unintended writing of pages Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org The check for laptop mode and sc->may_writepage is intended to not write pages if either laptop mode is set or we are not allowed to write. The && there means that currently pages may be written in laptop mode and during zone_reclaim. This patch also applies to 2.6.15 and 2.6.14! Signed-off-by: Christoph Lameter Index: linux-2.6.16-rc1-mm1/mm/vmscan.c =================================================================== --- linux-2.6.16-rc1-mm1.orig/mm/vmscan.c 2006-01-19 15:40:28.000000000 -0800 +++ linux-2.6.16-rc1-mm1/mm/vmscan.c 2006-01-19 15:40:30.000000000 -0800 @@ -491,7 +491,7 @@ static int shrink_list(struct list_head goto keep_locked; if (!may_enter_fs) goto keep_locked; - if (laptop_mode && !sc->may_writepage) + if (laptop_mode || !sc->may_writepage) goto keep_locked; /* Page is dirty, try to write it out here */