From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932285AbVJIUQf (ORCPT ); Sun, 9 Oct 2005 16:16:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932286AbVJIUQf (ORCPT ); Sun, 9 Oct 2005 16:16:35 -0400 Received: from smtp.osdl.org ([65.172.181.4]:19608 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932285AbVJIUQf (ORCPT ); Sun, 9 Oct 2005 16:16:35 -0400 Date: Sun, 9 Oct 2005 13:16:33 -0700 (PDT) From: Linus Torvalds To: "Paolo 'Blaisorblade' Giarrusso" cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix ext3 warning for unused var In-Reply-To: <20051009195850.27237.90873.stgit@zion.home.lan> Message-ID: References: <20051009195850.27237.90873.stgit@zion.home.lan> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 9 Oct 2005, Paolo 'Blaisorblade' Giarrusso wrote: > > Can please someone merge this? It's the 3rd time I send it. I don't like #ifdef's in code. You could just have split up the quota-specific stuff into a function of their own: "ext3_show_quota_options()". The patch might have been larger, but it would actually clean up the code rather than make it uglier. Warnings are not a reason for ugly code. Linus