From: Zwane Mwaikambo <zwane@arm.linux.org.uk>
To: Andi Kleen <ak@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
William Lee Irwin III <wli@holomorphy.com>,
"Raj, Ashok" <ashok.raj@intel.com>
Subject: Re: x86_64/HOTPLUG_CPU: NULL dereference doesn't #PF with init_level4_pgt
Date: Thu, 1 Dec 2005 11:34:13 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0512010924490.13220@montezuma.fsmlabs.com> (raw)
In-Reply-To: <20051201131857.GG19515@wotan.suse.de>
On Thu, 1 Dec 2005, Andi Kleen wrote:
> On Wed, Nov 30, 2005 at 08:03:33PM -0800, Zwane Mwaikambo wrote:
> > NULL dereferences don't cause a page fault if the 4th level pagetable
> > being used is init_level4_pgt because we never zap_low_mappings. Since
> > the idle thread uses init_level4_pgt any bad dereferences happening there
> > (e.g. from interrupts) won't cause a fault. Andi would you be fine with
> > switching the idle threads to a different level4?
>
> That recently changed. Are you sure it's still the case?
>
> idle threads should always run with lazy TLB, no different mms.
> That's important for performance.
>
> If a NULL reference causes a oops or not depends on if user space
> from the last process mapped a page to NULL or not.
Ah thanks Andi, yes NULL reference causes an oops in the current -git
repository, i hadn't seen that change so i had last tested it on 2.6.13.
Sorry for the noise.
Zwane
prev parent reply other threads:[~2005-12-01 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-01 4:03 Zwane Mwaikambo
2005-12-01 13:18 ` Andi Kleen
2005-12-01 19:34 ` Zwane Mwaikambo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0512010924490.13220@montezuma.fsmlabs.com \
--to=zwane@arm.linux.org.uk \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®