From: Linus Torvalds <torvalds@osdl.org>
To: "Paul E. McKenney" <paulmck@us.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [patch, lock validator] fix uidhash_lock <-> RCU deadlock
Date: Fri, 27 Jan 2006 19:22:15 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0601271920000.3192@evo.osdl.org> (raw)
In-Reply-To: <20060126111352.GF4953@us.ibm.com>
On Thu, 26 Jan 2006, Paul E. McKenney wrote:
>
> On Wed, Jan 25, 2006 at 03:23:07PM +0100, Ingo Molnar wrote:
> > RCU task-struct freeing can call free_uid(), which is taking
> > uidhash_lock - while other users of uidhash_lock are softirq-unsafe.
>
> I guess I get to feel doubly stupid today. Good catch, great tool!!!
I wonder if the right fix wouldn't be to free the user struct early,
instead of freeing it from RCU. Hmm?
Linus
next prev parent reply other threads:[~2006-01-28 0:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 14:23 Ingo Molnar
2006-01-25 16:59 ` Daniel Walker
2006-01-29 13:55 ` Ingo Molnar
2006-01-26 11:13 ` Paul E. McKenney
2006-01-28 0:22 ` Linus Torvalds [this message]
2006-01-28 2:40 ` Paul E. McKenney
2006-01-30 4:14 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0601271920000.3192@evo.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®