From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1751288AbWCLNzy@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751288AbWCLNzy (ORCPT <rfc822;willy@w.ods.org>);
	Sun, 12 Mar 2006 08:55:54 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751480AbWCLNzy
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sun, 12 Mar 2006 08:55:54 -0500
Received: from scrub.xs4all.nl ([194.109.195.176]:660 "EHLO scrub.xs4all.nl")
	by vger.kernel.org with ESMTP id S1751288AbWCLNzy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 12 Mar 2006 08:55:54 -0500
Date: Sun, 12 Mar 2006 14:55:49 +0100 (CET)
From: Roman Zippel <zippel@linux-m68k.org>
X-X-Sender: roman@scrub.home
To: Thomas Gleixner <tglx@linutronix.de>
cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>,
       Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch 5/8] hrtimer remove state field
In-Reply-To: <1142170505.19916.402.camel@localhost.localdomain>
Message-ID: <Pine.LNX.4.64.0603121444530.16802@scrub.home>
References: <20060312080316.826824000@localhost.localdomain> 
 <20060312080332.274315000@localhost.localdomain>  <Pine.LNX.4.64.0603121302590.16802@scrub.home>
  <1142169010.19916.397.camel@localhost.localdomain> 
 <Pine.LNX.4.64.0603121422180.16802@scrub.home> <1142170505.19916.402.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Sun, 12 Mar 2006, Thomas Gleixner wrote:

> On Sun, 2006-03-12 at 14:26 +0100, Roman Zippel wrote:
> > > softirq runs on CPU0
> > > base->lock()
> > > 
> > > remove_timer(timer);
> > > 
> > > base->unlock()
> > > 			signal of previous expiry is delivered on CPU1
> > > 			timer is reqeued.
> 
> 		------->  sig_ignore is set

??? I can't find any symbol 'sig_ignore'.

> > > requeue = timer->fn();
> > > 
> > > base->lock()
> > > 
> > > if (requeue)
> > > 	enqueue_timer(timer)
> > > 

What actually happened is that requeue is false and in the meantime the 
timer was restarted on another cpu via signal delivery and 
run_hrtimer_queue would set the state to expired, while the timer was 
still active -> OOPS.

bye, Roman