mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hua Zhong <hzhong@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, axboe@suse.de
Subject: [PATCH] likely cleanup: revert unlikely in ll_back_merge_fn
Date: Tue, 25 Apr 2006 11:18:02 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0604251112490.5810@localhost.localdomain> (raw)

With likely/unlikely profiling (see the recent patch dwalker@mvista.com sent), on my not-so-busy-typical-development system it shows more than 80K misses and no hits. So I guess it makes sense to revert.

I don't know BIO code very well, but I hope this data is useful for the experts.

Signed-off-by: Hua Zhong <hzhong@gmail.com>

diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c
index 1755c05..499da1c 100644
--- a/block/ll_rw_blk.c
+++ b/block/ll_rw_blk.c
@@ -1432,7 +1432,7 @@ static int ll_back_merge_fn(request_queu
  	}
  	if (unlikely(!bio_flagged(req->biotail, BIO_SEG_VALID)))
  		blk_recount_segments(q, req->biotail);
-	if (unlikely(!bio_flagged(bio, BIO_SEG_VALID)))
+	if (likely(!bio_flagged(bio, BIO_SEG_VALID)))
  		blk_recount_segments(q, bio);
  	len = req->biotail->bi_hw_back_size + bio->bi_hw_front_size;
  	if (BIOVEC_VIRT_MERGEABLE(__BVEC_END(req->biotail), __BVEC_START(bio)) &&

             reply	other threads:[~2006-04-25 18:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-25 18:18 Hua Zhong [this message]
2006-04-25 18:30 ` Jens Axboe
2006-04-25 21:38   ` Hua Zhong
2006-04-26  5:20     ` Jens Axboe
2006-04-26 13:50       ` James Bottomley
2006-04-26 13:55         ` Jens Axboe
2006-04-26 14:24           ` James Bottomley
2006-04-27 14:39             ` Jens Axboe
2006-04-26 17:06   ` Hua Zhong
2006-04-30 19:25   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0604251112490.5810@localhost.localdomain \
    --to=hzhong@gmail.com \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®