From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964867AbWEBPF3 (ORCPT ); Tue, 2 May 2006 11:05:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964866AbWEBPF3 (ORCPT ); Tue, 2 May 2006 11:05:29 -0400 Received: from smtp.osdl.org ([65.172.181.4]:54179 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S964868AbWEBPFK (ORCPT ); Tue, 2 May 2006 11:05:10 -0400 Date: Tue, 2 May 2006 08:05:01 -0700 (PDT) From: Linus Torvalds To: Neil Brown cc: Alan Cox , Stephen Hemminger , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: better leve triggered IRQ management needed In-Reply-To: <17494.59866.493671.504666@cse.unsw.edu.au> Message-ID: References: <20060424114105.113eecac@localhost.localdomain> <1146345911.3302.36.camel@localhost.localdomain> <17492.16811.469245.331326@cse.unsw.edu.au> <17492.21870.649828.686244@cse.unsw.edu.au> <17494.59866.493671.504666@cse.unsw.edu.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 May 2006, Neil Brown wrote: > > Maybe the eisa_set_level_irq should be passed 'irq' rather than 'newirq' > ?? Yeah, stupid cut-and-paste error (the eisa_set_level_irq() call _is_ already there in the PCI irq setting, for the case where we actually have to set up routing that didn't exist before). That's also why I'm a bit nervous even about my stupid one-liner patch: if the irq routing is already set up, and we just use the irq we're told to use, I'm not sure we should touch ELCR even if it "looks wrong". It obviously works on your machine, but I wonder what could break on others.. Linus