From: James Morris <jmorris@namei.org>
To: Sridhar Samudrala <sri@us.ibm.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH 2/2] update sunrpc to use in-kernel sockets API
Date: Tue, 13 Jun 2006 10:07:45 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0606131006250.3553@d.namei> (raw)
In-Reply-To: <448E42AE.1010901@us.ibm.com>
On Mon, 12 Jun 2006, Sridhar Samudrala wrote:
> > > - sendpage = sock->ops->sendpage ? : sock_no_sendpage;
> > > + sendpage = kernel_sendpage ? : sock_no_sendpage;
> > >
> >
> > This is not equivalent.
> >
> >
> Actually, we could make this a simple assignment as we check for
> sock->ops->sendpage in
> kernel_sendpage().
> sendpage = kernel_sendpage;
No, the code there is setting different values for sendpage depending on
whether the page is in high memory or not.
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2006-06-13 14:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-12 23:56 Sridhar Samudrala
2006-06-13 3:25 ` James Morris
2006-06-13 4:44 ` Sridhar Samudrala
2006-06-13 14:07 ` James Morris [this message]
2006-06-13 16:20 ` Sridhar Samudrala
2006-06-13 22:13 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606131006250.3553@d.namei \
--to=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®