From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S932240AbWGGSxd@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932240AbWGGSxd (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 7 Jul 2006 14:53:33 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932245AbWGGSxd
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 7 Jul 2006 14:53:33 -0400
Received: from lucidpixels.com ([66.45.37.187]:37253 "EHLO lucidpixels.com")
	by vger.kernel.org with ESMTP id S932240AbWGGSxc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 7 Jul 2006 14:53:32 -0400
Date: Fri, 7 Jul 2006 14:53:31 -0400 (EDT)
From: Justin Piszcz <jpiszcz@lucidpixels.com>
X-X-Sender: jpiszcz@p34.internal.lan
To: Mark Lord <liml@rtr.ca>
cc: Sander <sander@humilis.net>, Jeff Garzik <jgarzik@pobox.com>,
       linux-kernel@vger.kernel.org,
       IDE/ATA development list <linux-ide@vger.kernel.org>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: LibPATA code issues / 2.6.15.4
In-Reply-To: <Pine.LNX.4.64.0607071035310.5153@p34.internal.lan>
Message-ID: <Pine.LNX.4.64.0607071452540.14371@p34.internal.lan>
References: <Pine.LNX.4.64.0602140439580.3567@p34> <200607070908.44751.liml@rtr.ca>
 <Pine.LNX.4.64.0607070923130.4099@p34.internal.lan> <200607070943.17957.liml@rtr.ca>
 <Pine.LNX.4.64.0607071035310.5153@p34.internal.lan>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org



On Fri, 7 Jul 2006, Justin Piszcz wrote:

>
>
> On Fri, 7 Jul 2006, Mark Lord wrote:
>
>> Justin Piszcz wrote:
>>> 
>>> had to change
>>> 
>>> KERN_WARN -> KERN_WARNING
>>> 
>>> then more errors
>> 
>> Eh?  After fixing the KERN_WARN -> KERN_WARNING part,
>> the patch compiles / links cleanly here on 2.6.17.
>> (fixed copy below).   Still untested, though.
>> 
>>> do you know who wrote the original patch?
>> 
>> I did.
>> 
>> Cheers
>> 
>> --- linux/drivers/scsi/libata-scsi.c.orig	2006-06-19 10:37:03.000000000 
>> -0400
>> +++ linux/drivers/scsi/libata-scsi.c	2006-07-07 09:06:57.000000000 -0400
>> @@ -542,6 +542,7 @@
>> 	struct ata_taskfile *tf = &qc->tf;
>> 	unsigned char *sb = cmd->sense_buffer;
>> 	unsigned char *desc = sb + 8;
>> +	unsigned char ata_op = tf->command;
>>
>> 	memset(sb, 0, SCSI_SENSE_BUFFERSIZE);
>> 
>> @@ -558,6 +559,7 @@
>> 	 * onto sense key, asc & ascq.
>> 	 */
>> 	if (tf->command & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {
>> +		printk(KERN_WARNING "ata_gen_ata_desc_sense: failed 
>> ata_op=0x%02x\n", ata_op);
>> 		ata_to_sense_error(qc->ap->id, tf->command, tf->feature,
>> 				   &sb[1], &sb[2], &sb[3]);
>> 		sb[1] &= 0x0f;
>> 
>
> Mark!! It did it again, here you go:
>
> ==> /p34/var/log/messages <==
> Jul  7 10:26:06 p34 kernel: [4296869.461000] ata4: status=0x53 { DriveReady 
> SeekComplete Index Error }
> Jul  7 10:26:06 p34 kernel: [4296869.461000] ata4: error=0x04 { 
> DriveStatusError }
> ==> /p34/var/log/kern.log <==
> Jul  7 10:26:06 p34 kernel: [4296869.461000] ata4: translated ATA stat/err 
> 0x53/04 to SCSI SK/ASC/ASCQ 0xb/00/00
> Jul  7 10:26:06 p34 kernel: [4296869.461000] ata4: status=0x53 { DriveReady 
> SeekComplete Index Error }
> Jul  7 10:26:06 p34 kernel: [4296869.461000] ata4: error=0x04 { 
> DriveStatusError }
>
> Does this help?
>
> Can we eliminate the cause of these errors now?
>
>

Jeff or Alan,

Does that ATA translation help in determining what *bad* commands are 
being sent to the drive?

This occurs on two separate identical disks.

Justin.