From: Justin Piszcz <jpiszcz@lucidpixels.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Mark Lord <liml@rtr.ca>, Sander <sander@humilis.net>,
linux-kernel@vger.kernel.org,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: LibPATA code issues / 2.6.15.4
Date: Fri, 7 Jul 2006 15:28:03 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0607071520160.2643@p34.internal.lan> (raw)
In-Reply-To: <44AEB3CA.8080606@pobox.com>
On Fri, 7 Jul 2006, Jeff Garzik wrote:
> Justin Piszcz wrote:
>>
>>
>> On Fri, 7 Jul 2006, Justin Piszcz wrote:
>>
>>>
>>>
>>> On Fri, 7 Jul 2006, Mark Lord wrote:
>>>
>>>> Justin Piszcz wrote:
>>>>>
>>>>> had to change
>>>>>
>>>>> KERN_WARN -> KERN_WARNING
>>>>>
>>>>> then more errors
>>>>
>>>> Eh? After fixing the KERN_WARN -> KERN_WARNING part,
>>>> the patch compiles / links cleanly here on 2.6.17.
>>>> (fixed copy below). Still untested, though.
>>>>
>>>>> do you know who wrote the original patch?
>>>>
>>>> I did.
>>>>
>>>> Cheers
>>>>
>>>> --- linux/drivers/scsi/libata-scsi.c.orig 2006-06-19
>>>> 10:37:03.000000000 -0400
>>>> +++ linux/drivers/scsi/libata-scsi.c 2006-07-07 09:06:57.000000000
>>>> -0400
>>>> @@ -542,6 +542,7 @@
>>>> struct ata_taskfile *tf = &qc->tf;
>>>> unsigned char *sb = cmd->sense_buffer;
>>>> unsigned char *desc = sb + 8;
>>>> + unsigned char ata_op = tf->command;
>>>>
>>>> memset(sb, 0, SCSI_SENSE_BUFFERSIZE);
>>>>
>>>> @@ -558,6 +559,7 @@
>>>> * onto sense key, asc & ascq.
>>>> */
>>>> if (tf->command & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {
>>>> + printk(KERN_WARNING "ata_gen_ata_desc_sense: failed
>>>> ata_op=0x%02x\n", ata_op);
>>>> ata_to_sense_error(qc->ap->id, tf->command, tf->feature,
>>>> &sb[1], &sb[2], &sb[3]);
>>>> sb[1] &= 0x0f;
>>>>
>>>
>>> Mark!! It did it again, here you go:
>>>
>>> ==> /p34/var/log/messages <==
>>> Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: status=0x53 {
>>> DriveReady SeekComplete Index Error }
>>> Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: error=0x04 {
>>> DriveStatusError }
>>> ==> /p34/var/log/kern.log <==
>>> Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: translated ATA stat/err
>>> 0x53/04 to SCSI SK/ASC/ASCQ 0xb/00/00
>>> Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: status=0x53 {
>>> DriveReady SeekComplete Index Error }
>>> Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: error=0x04 {
>>> DriveStatusError }
>>>
>>> Does this help?
>>>
>>> Can we eliminate the cause of these errors now?
>>>
>>>
>>
>> Jeff or Alan,
>>
>> Does that ATA translation help in determining what *bad* commands are being
>> sent to the drive?
>
> No, it needs the patch that Mark has been posting...
>
> Jeff
>
>
>
Jeff, the patch is applied and box booted the new kernel and I reproduced
the error messages, THAT is what is produced with the patch.
Without the patch:
Jun 18 07:09:53 p34 kernel: [4297678.777000] ata3: status=0x51 {
DriveReady SeekComplete Error }
Jun 18 07:09:53 p34 kernel: [4297678.777000] ata3: error=0x04 {
DriveStatusError }
Jun 18 07:20:08 p34 -- MARK --
Jun 18 07:27:31 p34 kernel: [4298736.905000] ata3: status=0x51 {
DriveReady SeekComplete Error }
Jun 18 07:27:31 p34 kernel: [4298736.905000] ata3: error=0x04 {
DriveStatusError }
With the patch:
Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: translated ATA stat/err
0x53/04 to SCSI SK/ASC/ASCQ 0xb/00/00
Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: status=0x53 {
DriveReady SeekComplete Index Error }
Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: error=0x04 {
DriveStatusError }
Jul 7 10:49:29 p34 kernel: [4298273.178000] ata4: translated ATA stat/err
0x51/04 to SCSI SK/ASC/ASCQ 0xb/00/00
Jul 7 10:49:29 p34 kernel: [4298273.178000] ata4: status=0x51 {
DriveReady SeekComplete Error }
Jul 7 10:49:29 p34 kernel: [4298273.178000] ata4: error=0x04 {
DriveStatusError }
Jul 7 11:43:02 p34 kernel: [4301488.359000] ata4: translated ATA stat/err
0x51/04 to SCSI SK/ASC/ASCQ 0xb/00/00
Jul 7 11:43:02 p34 kernel: [4301488.359000] ata4: status=0x51 {
DriveReady SeekComplete Error }
Jul 7 11:43:02 p34 kernel: [4301488.359000] ata4: error=0x04 {
DriveStatusError }
Jul 7 12:35:27 p34 kernel: [4304634.600000] ata4: translated ATA stat/err
0x51/04 to SCSI SK/ASC/ASCQ 0xb/00/00
Jul 7 12:35:27 p34 kernel: [4304634.600000] ata4: status=0x51 {
DriveReady SeekComplete Error }
Jul 7 12:35:27 p34 kernel: [4304634.600000] ata4: error=0x04 {
DriveStatusError }
Jul 7 12:44:14 p34 kernel: [4305162.220000] ata4: no sense translation
for status: 0x51
Jul 7 12:44:14 p34 kernel: [4305162.220000] ata4: translated ATA stat/err
0x51/00 to SCSI SK/ASC/ASCQ 0xb/00/00
Jul 7 12:44:14 p34 kernel: [4305162.220000] ata4: status=0x51 {
DriveReady SeekComplete Error }
Jul 7 13:03:22 p34 kernel: [4306309.782000] ata4: translated ATA stat/err
0x51/04 to SCSI SK/ASC/ASCQ 0xb/00/00
Jul 7 13:03:22 p34 kernel: [4306309.782000] ata4: status=0x51 {
DriveReady SeekComplete Error }
Jul 7 13:03:22 p34 kernel: [4306309.782000] ata4: error=0x04 {
DriveStatusError }
Jul 7 13:05:12 p34 kernel: [4306419.891000] ata4: no sense translation
for status: 0x51
Jul 7 13:05:12 p34 kernel: [4306419.891000] ata4: translated ATA stat/err
0x51/00 to SCSI SK/ASC/ASCQ 0xb/00/00
Jul 7 13:05:12 p34 kernel: [4306419.891000] ata4: status=0x51 {
DriveReady SeekComplete Error }
Jul 7 13:32:20 p34 kernel: [4308048.717000] ata4: translated ATA stat/err
0x51/04 to SCSI SK/ASC/ASCQ 0xb/00/00
Jul 7 13:32:20 p34 kernel: [4308048.717000] ata4: status=0x51 {
DriveReady SeekComplete Error }
Jul 7 13:32:20 p34 kernel: [4308048.717000] ata4: error=0x04 {
DriveStatusError }
When I had been running it earlier with 2.6.15.x:
Mar 1 13:31:10 p34 kernel: [4295292.736000] +++PATCH: Original kernel
error:
Mar 1 13:31:10 p34 kernel: [4295292.736000] ata3: translated op=0x85 ATA
stat/err 0x51/04 to SCSI SK/ASC/ASCQ 0xb/00/00
Mar 1 13:31:10 p34 kernel: [4295292.736000] +++PATCH: Mark Lord's
extended verbosity patch:
Mar 1 13:31:10 p34 kernel: [4295292.736000] ata3: translated op=0x85
cmd=0xb0 ATA stat/err 0x51/04 to SCSI SK/ASC/ASCQ 0xb/00/00
Mar 1 13:31:10 p34 kernel: [4295292.736000] ata3: status=0x51 {
DriveReady SeekComplete Error }
Mar 1 13:31:10 p34 kernel: [4295292.736000] ata3: error=0x04 {
DriveStatusError }
Mar 1 13:31:10 p34 kernel: [4295292.736000] +++PATCH: Original kernel
error:
Mar 1 13:31:10 p34 kernel: [4295292.736000] ata3: translated op=0x85 ATA
stat/err 0x51/04 to SCSI SK/ASC/ASCQ 0xb/00/00
Mar 1 13:31:10 p34 kernel: [4295292.736000] +++PATCH: Mark Lord's
extended verbosity patch:
Mar 1 13:31:10 p34 kernel: [4295292.736000] ata3: translated op=0x85
cmd=0xb0 ATA stat/err 0x51/04 to SCSI SK/ASC/ASCQ 0xb/00/00
Mar 1 13:31:10 p34 kernel: [4295292.736000] ata3: status=0x51 {
DriveReady SeekComplete Error }
Mar 1 13:31:10 p34 kernel: [4295292.736000] ata3: error=0x04 {
DriveStatusError }
Perhaps the patch is not printing out the correct error message?
This shows that the source file was patched in libata-scsi.c.
/*
* Use ata_to_sense_error() to map status register bits
* onto sense key, asc & ascq.
*/
if (tf->command & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {
printk(KERN_WARNING "ata_gen_ata_desc_sense: failed
ata_op=0x%02x\n", ata_op);
ata_to_sense_error(qc->ap->id, tf->command, tf->feature,
&sb[1], &sb[2], &sb[3]);
sb[1] &= 0x0f;
}
This shows the kernel version.
$ cat /usr/src/linux/.version
4
This shows I am running the patched version.
$ uname -a
Linux p34.internal.lan 2.6.17.3 #4 SMP PREEMPT Fri Jul 7 09:47:53 EDT 2006
i686 GNU/Linux
$
Maybe something is blocking the opcode output from showing correctly?
Justin.
next prev parent reply other threads:[~2006-07-07 19:28 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-14 9:48 Justin Piszcz
2006-02-14 14:50 ` Mark Lord
2006-02-14 16:27 ` David Greaves
2006-02-14 17:12 ` Justin Piszcz
2006-02-14 18:00 ` Mark Lord
2006-02-14 18:06 ` Justin Piszcz
2006-02-23 23:39 ` Justin Piszcz
2006-02-25 15:32 ` Mark Lord
2006-02-25 15:58 ` Justin Piszcz
2006-02-25 16:11 ` Jesper Juhl
2006-02-25 16:21 ` Mark Lord
2006-02-25 11:34 ` David Greaves
2006-02-25 16:20 ` Mark Lord
2006-02-25 17:45 ` Justin Piszcz
2006-02-25 18:28 ` Mark Lord
2006-02-25 18:55 ` Justin Piszcz
2006-02-25 19:29 ` Justin Piszcz
2006-02-25 19:53 ` David Greaves
2006-02-25 19:47 ` David Greaves
2006-02-26 2:27 ` Mark Lord
2006-02-26 9:56 ` David Greaves
2006-02-26 14:04 ` Mark Lord
2006-02-27 21:34 ` Mark Lord
2006-02-28 1:33 ` Tejun Heo
2006-02-28 1:46 ` Linus Torvalds
2006-02-28 2:07 ` Jeff Garzik
2006-02-28 2:14 ` Linus Torvalds
2006-02-28 2:52 ` Jeff Garzik
2006-02-28 3:36 ` Jeff Garzik
2006-02-28 4:11 ` Mark Lord
2006-02-28 10:30 ` Alan Cox
2006-02-28 8:03 ` Jens Axboe
2006-02-28 4:16 ` Mark Lord
2006-02-28 10:32 ` Alan Cox
2006-02-28 10:30 ` Justin Piszcz
2006-02-28 10:39 ` David Greaves
2006-02-28 14:37 ` Mark Lord
2006-02-28 21:04 ` Bill Davidsen
2006-03-08 2:57 ` Mark Lord
2006-03-08 3:18 ` Dave Jones
2006-03-08 3:23 ` Mark Lord
2006-03-08 15:37 ` Bill Davidsen
2006-02-28 14:38 ` Mark Lord
2006-02-28 15:16 ` Alan Cox
2006-03-01 17:33 ` David Greaves
2006-03-01 18:37 ` Alan Cox
2006-03-01 20:12 ` Phillip Susi
2006-03-08 16:46 ` Alan Cox
2006-02-28 15:31 ` Mark Lord
2006-02-28 15:34 ` Jeff Garzik
2006-02-28 16:57 ` Eric D. Mudama
2006-03-01 1:04 ` Mark Lord
2006-03-01 11:37 ` Justin Piszcz
2006-03-01 13:17 ` Justin Piszcz
2006-03-01 17:41 ` David Greaves
2006-03-01 17:46 ` Mark Lord
2006-03-01 18:12 ` David Greaves
2006-03-01 18:30 ` Mark Lord
2006-03-01 18:32 ` Justin Piszcz
2006-03-01 18:33 ` Justin Piszcz
2006-03-01 18:48 ` David Greaves
2006-03-01 19:49 ` David Greaves
2006-03-03 19:38 ` Justin Piszcz
2006-03-03 22:46 ` David Greaves
2006-03-04 14:25 ` Mark Lord
2006-03-06 6:13 ` David Greaves
2006-03-21 18:11 ` David Greaves
2006-03-22 15:23 ` David Greaves
2006-03-05 11:43 ` Justin Piszcz
2006-03-05 12:41 ` Justin Piszcz
2006-03-05 22:58 ` Mark Lord
2006-03-05 23:00 ` Mark Lord
2006-03-05 23:19 ` Justin Piszcz
2006-03-05 23:39 ` Jeff Garzik
2006-04-21 19:14 ` LibPATA code issues / 2.6.16 (previously, 2.6.15.x) Justin Piszcz
2006-04-21 19:18 ` Jeff Garzik
2006-04-21 19:28 ` Linus Torvalds
2006-04-21 22:46 ` Jeff Garzik
2006-04-22 0:05 ` Linus Torvalds
2006-05-06 15:09 ` [smartmontools-support]Re: " Leon Woestenberg
2006-05-07 12:44 ` Ingo Oeser
2006-06-11 11:13 ` Justin Piszcz
2006-03-01 19:06 ` LibPATA code issues / 2.6.15.4 Justin Piszcz
2006-03-01 19:28 ` Mark Lord
2006-03-01 19:35 ` Mark Lord
2006-03-01 19:38 ` Justin Piszcz
2006-03-01 19:41 ` Jeff Garzik
2006-02-26 12:27 ` James Courtier-Dutton
2006-02-26 12:55 ` David Greaves
2006-02-26 13:56 ` Mark Lord
2006-02-26 14:30 ` Kernel SeekCompleteErrors... Different from " James Courtier-Dutton
2006-02-26 17:03 ` Mark Lord
2006-02-26 17:13 ` Dr. David Alan Gilbert
2006-02-26 17:43 ` Alan Cox
2006-02-26 20:36 ` Mark Lord
2006-02-27 11:48 ` Alan Cox
2006-02-27 13:40 ` Mark Lord
2006-02-14 23:58 ` Justin Piszcz
2006-02-17 8:45 ` Jeff Garzik
2006-02-17 14:59 ` Mark Lord
2006-02-17 15:00 ` Justin Piszcz
2006-02-18 20:43 ` Sander
2006-02-18 21:42 ` Mark Lord
2006-02-18 21:51 ` Justin Piszcz
2006-02-19 7:14 ` Sander
2006-02-19 15:30 ` Mark Lord
2006-02-19 17:16 ` Sander
2006-07-06 23:08 ` Justin Piszcz
2006-07-07 13:08 ` Mark Lord
2006-07-07 13:24 ` Justin Piszcz
2006-07-07 13:43 ` Mark Lord
2006-07-07 13:48 ` Justin Piszcz
2006-07-07 14:01 ` Justin Piszcz
2006-07-07 14:35 ` Justin Piszcz
2006-07-07 18:53 ` Justin Piszcz
2006-07-07 19:19 ` Jeff Garzik
2006-07-07 19:28 ` Justin Piszcz [this message]
[not found] ` <200607091224.31451.liml@rtr.ca>
2006-07-09 17:27 ` Justin Piszcz
2006-07-09 20:16 ` Justin Piszcz
2006-07-09 20:40 ` LibPATA code issues / 2.6.15.4 (found the opcode=0x35)! Justin Piszcz
2006-07-09 20:46 ` Justin Piszcz
2006-07-09 21:05 ` Justin Piszcz
2006-07-09 22:03 ` Justin Piszcz
2006-07-10 13:59 ` Follow up? " Justin Piszcz
2006-07-10 15:33 ` Alan Cox
2006-07-10 15:45 ` Justin Piszcz
2006-07-11 13:28 ` LibPATA code issues / 2.6.17.3 (What is the next step?) Justin Piszcz
2006-07-11 16:12 ` Alan Cox
2006-07-12 22:10 ` David Greaves
2006-07-12 22:29 ` Justin Piszcz
2006-07-14 15:33 ` David Greaves
2006-07-13 10:55 ` Erik Mouw
2006-07-14 17:16 ` Mark Lord
2006-07-14 17:18 ` Justin Piszcz
2006-07-14 17:39 ` Mark Lord
2006-07-14 18:18 ` Justin Piszcz
2006-07-14 20:02 ` Mark Lord
2006-07-14 17:14 ` Follow up? LibPATA code issues / 2.6.15.4 (found the opcode=0x35)! Mark Lord
2006-07-14 17:17 ` Justin Piszcz
2006-07-14 17:37 ` Mark Lord
2006-07-14 18:17 ` Justin Piszcz
2006-03-01 19:00 LibPATA code issues / 2.6.15.4 Nicolas Mailhot
2006-03-01 19:22 ` Mark Lord
2006-03-01 23:12 ` Nicolas Mailhot
2006-03-01 23:31 ` Jeff Garzik
2006-03-02 1:19 ` Eric D. Mudama
2006-03-02 1:39 ` Eric D. Mudama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0607071520160.2643@p34.internal.lan \
--to=jpiszcz@lucidpixels.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sander@humilis.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®