From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422661AbWGJPp3 (ORCPT ); Mon, 10 Jul 2006 11:45:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422665AbWGJPp3 (ORCPT ); Mon, 10 Jul 2006 11:45:29 -0400 Received: from lucidpixels.com ([66.45.37.187]:55470 "EHLO lucidpixels.com") by vger.kernel.org with ESMTP id S1422666AbWGJPp2 (ORCPT ); Mon, 10 Jul 2006 11:45:28 -0400 Date: Mon, 10 Jul 2006 11:45:26 -0400 (EDT) From: Justin Piszcz X-X-Sender: jpiszcz@p34.internal.lan To: Alan Cox cc: Mark Lord , Jeff Garzik , Sander , linux-kernel@vger.kernel.org, IDE/ATA development list Subject: Re: Follow up? LibPATA code issues / 2.6.15.4 (found the opcode=0x35)! In-Reply-To: <1152545639.27368.137.camel@localhost.localdomain> Message-ID: References: <44AEB3CA.8080606@pobox.com> <200607091224.31451.liml@rtr.ca> <1152545639.27368.137.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-1463747160-1598758656-1152546326=:3591" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463747160-1598758656-1152546326=:3591 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Please verify I did the patch correctly, thanks. On Mon, 10 Jul 2006, Alan Cox wrote: > Ar Llu, 2006-07-10 am 09:59 -0400, ysgrifennodd Justin Piszcz: >>> [4297741.057000] ata_gen_fixed_sense: failed ata_op=0x35 >>> [4297741.057000] ata4: translated ATA stat/err 0x51/04 to SCSI SK/ASC/ASCQ >>> 0xb/00/00 >>> [4297741.057000] ata_gen_ata_desc_sense: failed ata_op=0x51 >>> [4297741.057000] ata4: status=0x51 { DriveReady SeekComplete Error } >>> [4297741.057000] ata4: error=0x04 { DriveStatusError } >>> >>> Also got a 0xca. > > Thats "write" so if that is reporting as an unknown command something > very odd indeed is happening. > > ---1463747160-1598758656-1152546326=:3591 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=libata-ata_op.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=libata-ata_op.patch ZGlmZiAtdXByTiBsaW51eC0yLjYuMTcuMy9kcml2ZXJzL3Njc2kvbGliYXRh LXNjc2kuYyBsaW51eC0yLjYuMTcuMy1kaWZmL2RyaXZlcnMvc2NzaS9saWJh dGEtc2NzaS5jDQotLS0gbGludXgtMi42LjE3LjMvZHJpdmVycy9zY3NpL2xp YmF0YS1zY3NpLmMJMjAwNi0wNi0zMCAxMzozNzozOC4wMDAwMDAwMDAgLTA0 MDANCisrKyBsaW51eC0yLjYuMTcuMy1kaWZmL2RyaXZlcnMvc2NzaS9saWJh dGEtc2NzaS5jCTIwMDYtMDctMDkgMTY6MzE6NDUuNjY1MTEyMDAwIC0wNDAw DQpAQCAtNDI4LDEwICs0MjgsMTYgQEAgaW50IGF0YV9zY3NpX2RldmljZV9z dXNwZW5kKHN0cnVjdCBzY3NpXw0KICAqCXNwaW5fbG9ja19pcnFzYXZlKGhv c3Rfc2V0IGxvY2spDQogICovDQogdm9pZCBhdGFfdG9fc2Vuc2VfZXJyb3Io dW5zaWduZWQgaWQsIHU4IGRydl9zdGF0LCB1OCBkcnZfZXJyLCB1OCAqc2ss IHU4ICphc2MsDQotCQkJdTggKmFzY3EpDQorCQkJdTggKmFzY3EsIHN0cnVj dCBhdGFfcXVldWVkX2NtZCAqcWMpDQogew0KIAlpbnQgaTsNCiANCisJc3Ry dWN0IHNjc2lfY21uZCAqY21kID0gcWMtPnNjc2ljbWQ7DQorCXN0cnVjdCBh dGFfdGFza2ZpbGUgKnRmID0gJnFjLT50ZjsNCisJdW5zaWduZWQgY2hhciAq c2IgPSBjbWQtPnNlbnNlX2J1ZmZlcjsNCisJdW5zaWduZWQgY2hhciAqZGVz YyA9IHNiICsgODsNCisJdW5zaWduZWQgY2hhciBhdGFfb3AgPSB0Zi0+Y29t bWFuZDsNCisJDQogCS8qIEJhc2VkIG9uIHRoZSAzd2FyZSBkcml2ZXIgdHJh bnNsYXRpb24gdGFibGUgKi8NCiAJc3RhdGljIGNvbnN0IHVuc2lnbmVkIGNo YXIgc2Vuc2VfdGFibGVbXVs0XSA9IHsNCiAJCS8qIEJCRHxFQ0N8SUR8TUFS ICovDQpAQCAtNTIwLDYgKzUyNiw3IEBAIHZvaWQgYXRhX3RvX3NlbnNlX2Vy cm9yKHVuc2lnbmVkIGlkLCB1OCANCiAJcHJpbnRrKEtFUk5fRVJSICJhdGEl dTogdHJhbnNsYXRlZCBBVEEgc3RhdC9lcnIgMHglMDJ4LyUwMnggdG8gIg0K IAkgICAgICAgIlNDU0kgU0svQVNDL0FTQ1EgMHgleC8lMDJ4LyUwMnhcbiIs IGlkLCBkcnZfc3RhdCwgZHJ2X2VyciwNCiAJICAgICAgICpzaywgKmFzYywg KmFzY3EpOw0KKwlwcmludGsoS0VSTl9FUlIgImF0YV9nZW5fYXRhX2Rlc2Nf c2Vuc2U6IGZhaWxlZCBhdGFfb3A9MHglMDJ4XG4iLCBhdGFfb3ApOw0KIAly ZXR1cm47DQogfQ0KIA0KQEAgLTU0Miw2ICs1NDksNyBAQCB2b2lkIGF0YV9n ZW5fYXRhX2Rlc2Nfc2Vuc2Uoc3RydWN0IGF0YV9xDQogCXN0cnVjdCBhdGFf dGFza2ZpbGUgKnRmID0gJnFjLT50ZjsNCiAJdW5zaWduZWQgY2hhciAqc2Ig PSBjbWQtPnNlbnNlX2J1ZmZlcjsNCiAJdW5zaWduZWQgY2hhciAqZGVzYyA9 IHNiICsgODsNCisJdW5zaWduZWQgY2hhciBhdGFfb3AgPSB0Zi0+Y29tbWFu ZDsNCiANCiAJbWVtc2V0KHNiLCAwLCBTQ1NJX1NFTlNFX0JVRkZFUlNJWkUp Ow0KIA0KQEAgLTU1OCw4ICs1NjYsOSBAQCB2b2lkIGF0YV9nZW5fYXRhX2Rl c2Nfc2Vuc2Uoc3RydWN0IGF0YV9xDQogCSAqIG9udG8gc2Vuc2Uga2V5LCBh c2MgJiBhc2NxLg0KIAkgKi8NCiAJaWYgKHRmLT5jb21tYW5kICYgKEFUQV9C VVNZIHwgQVRBX0RGIHwgQVRBX0VSUiB8IEFUQV9EUlEpKSB7DQorCQlwcmlu dGsoS0VSTl9XQVJOSU5HICJhdGFfZ2VuX2F0YV9kZXNjX3NlbnNlOiBmYWls ZWQgYXRhX29wPTB4JTAyeFxuIiwgYXRhX29wKTsNCiAJCWF0YV90b19zZW5z ZV9lcnJvcihxYy0+YXAtPmlkLCB0Zi0+Y29tbWFuZCwgdGYtPmZlYXR1cmUs DQotCQkJCSAgICZzYlsxXSwgJnNiWzJdLCAmc2JbM10pOw0KKwkJCQkgICAm c2JbMV0sICZzYlsyXSwgJnNiWzNdLHFjKTsNCiAJCXNiWzFdICY9IDB4MGY7 DQogCX0NCiANCkBAIC02MTcsNiArNjI2LDcgQEAgdm9pZCBhdGFfZ2VuX2Zp eGVkX3NlbnNlKHN0cnVjdCBhdGFfcXVldQ0KIAlzdHJ1Y3Qgc2NzaV9jbW5k ICpjbWQgPSBxYy0+c2NzaWNtZDsNCiAJc3RydWN0IGF0YV90YXNrZmlsZSAq dGYgPSAmcWMtPnRmOw0KIAl1bnNpZ25lZCBjaGFyICpzYiA9IGNtZC0+c2Vu c2VfYnVmZmVyOw0KKwl1bnNpZ25lZCBjaGFyIGF0YV9vcCA9IHRmLT5jb21t YW5kOw0KIA0KIAltZW1zZXQoc2IsIDAsIFNDU0lfU0VOU0VfQlVGRkVSU0la RSk7DQogDQpAQCAtNjMzLDggKzY0Myw5IEBAIHZvaWQgYXRhX2dlbl9maXhl ZF9zZW5zZShzdHJ1Y3QgYXRhX3F1ZXUNCiAJICogb250byBzZW5zZSBrZXks IGFzYyAmIGFzY3EuDQogCSAqLw0KIAlpZiAodGYtPmNvbW1hbmQgJiAoQVRB X0JVU1kgfCBBVEFfREYgfCBBVEFfRVJSIHwgQVRBX0RSUSkpIHsNCisJCXBy aW50ayhLRVJOX1dBUk5JTkcgImF0YV9nZW5fZml4ZWRfc2Vuc2U6IGZhaWxl ZCBhdGFfb3A9MHglMDJ4XG4iLCBhdGFfb3ApOw0KIAkJYXRhX3RvX3NlbnNl X2Vycm9yKHFjLT5hcC0+aWQsIHRmLT5jb21tYW5kLCB0Zi0+ZmVhdHVyZSwN Ci0JCQkJICAgJnNiWzJdLCAmc2JbMTJdLCAmc2JbMTNdKTsNCisJCQkJICAg JnNiWzJdLCAmc2JbMTJdLCAmc2JbMTNdLHFjKTsNCiAJCXNiWzJdICY9IDB4 MGY7DQogCX0NCiANCg== ---1463747160-1598758656-1152546326=:3591--