From: Roman Zippel <zippel@linux-m68k.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 3/3] kconfig/lxdialog: add bluetitle color scheme
Date: Mon, 24 Jul 2006 15:37:19 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0607241529280.6761@scrub.home> (raw)
In-Reply-To: <20060724131528.GB23210@mars.ravnborg.org>
Hi,
On Mon, 24 Jul 2006, Sam Ravnborg wrote:
> I blindly replaced yellow with blue.
> New version looks like this:
> static void set_bluetitle_theme(void)
> {
> DLG_MODIFY(title, COLOR_BLUE, COLOR_WHITE, true);
> DLG_MODIFY(tag, COLOR_BLUE, COLOR_WHITE, true);
> DLG_MODIFY(tag_key, COLOR_BLUE, COLOR_WHITE, true);
> }
The theme below should be a bit better and more consistent, selected text
is always white on blue with a yellow key character.
> The classic color scheme is quite readable on my display.
On mnay displays (especially lcd's) the difference between yellow and
white is very small, so that the text almost disappears.
bye, Roman
---
scripts/kconfig/lxdialog/util.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
Index: linux-2.6-git/scripts/kconfig/lxdialog/util.c
===================================================================
--- linux-2.6-git.orig/scripts/kconfig/lxdialog/util.c 2006-07-24 15:00:16.000000000 +0200
+++ linux-2.6-git/scripts/kconfig/lxdialog/util.c 2006-07-24 15:27:20.000000000 +0200
@@ -104,14 +104,13 @@ static void set_blackbg_theme(void)
static void set_bluetitle_theme(void)
{
- DLG_MODIFY(title, COLOR_BLUE, COLOR_WHITE, true);
- DLG_MODIFY(button_label_active, COLOR_BLUE, COLOR_BLUE, true);
- DLG_MODIFY(searchbox_title, COLOR_BLUE, COLOR_WHITE, true);
- DLG_MODIFY(position_indicator, COLOR_BLUE, COLOR_WHITE, true);
- DLG_MODIFY(tag, COLOR_BLUE, COLOR_WHITE, true);
- DLG_MODIFY(tag_selected, COLOR_BLUE, COLOR_BLUE, true);
- DLG_MODIFY(tag_key, COLOR_BLUE, COLOR_WHITE, true);
- DLG_MODIFY(tag_key_selected, COLOR_BLUE, COLOR_BLUE, true);
+ DLG_MODIFY(title, COLOR_BLUE, COLOR_WHITE, true);
+ DLG_MODIFY(button_key_active, COLOR_YELLOW, COLOR_BLUE, true);
+ DLG_MODIFY(button_label_active, COLOR_WHITE, COLOR_BLUE, true);
+ DLG_MODIFY(searchbox_title, COLOR_BLUE, COLOR_WHITE, true);
+ DLG_MODIFY(position_indicator, COLOR_BLUE, COLOR_WHITE, true);
+ DLG_MODIFY(tag, COLOR_BLUE, COLOR_WHITE, true);
+ DLG_MODIFY(tag_key, COLOR_BLUE, COLOR_WHITE, true);
}
static void init_one_color(struct dialog_color *color)
prev parent reply other threads:[~2006-07-24 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 11:36 [PATCH 0/3] kconfig/lxdialog: color theme support Sam Ravnborg
2006-07-24 11:37 ` [PATCH 1/3] kconfig/lxdialog: refactored color settings Sam Ravnborg
2006-07-24 11:38 ` [PATCH 2/3] kconfig/lxdialog: add support for color themes and add blackbg theme Sam Ravnborg
2006-07-24 12:25 ` Roman Zippel
2006-07-24 13:04 ` Sam Ravnborg
2006-07-24 11:39 ` [PATCH 3/3] kconfig/lxdialog: add bluetitle color scheme Sam Ravnborg
2006-07-24 12:28 ` Roman Zippel
2006-07-24 13:15 ` Sam Ravnborg
2006-07-24 13:37 ` Roman Zippel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0607241529280.6761@scrub.home \
--to=zippel@linux-m68k.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®