From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org
Subject: 2.6.18-rc3-mm2 early_param mem= fix
Date: Sun, 6 Aug 2006 18:22:04 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0608061811030.19637@blonde.wat.veritas.com> (raw)
I was impressed by how fast 2.6.18-rc3-mm2 is under memory pressure,
until I noticed that my "mem=512M" boot option was doing nothing. The
two fixes below got it working, but I wonder how many other early_param
"option=" args are wrong (e.g. "memmap=" in the same file): x86_64
shows many such, i386 shows only one, I've not followed it up further.
Hugh
--- 2.6.18-rc3-mm2/arch/x86_64/kernel/e820.c 2006-08-06 12:25:35.000000000 +0100
+++ linux/arch/x86_64/kernel/e820.c 2006-08-06 18:05:33.000000000 +0100
@@ -646,11 +646,11 @@ static int __init parse_memopt(char *p)
{
if (!p)
return -EINVAL;
- end_user_pfn = memparse(p, NULL);
+ end_user_pfn = memparse(p, &p);
end_user_pfn >>= PAGE_SHIFT;
return 0;
}
-early_param("mem=", parse_memopt);
+early_param("mem", parse_memopt);
static int userdef __initdata;
next reply other threads:[~2006-08-06 17:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-06 17:22 Hugh Dickins [this message]
2006-08-06 17:31 ` Hugh Dickins
2006-08-07 15:08 ` Andy Whitcroft
2006-08-07 21:09 ` Eric W. Biederman
2006-08-09 0:10 ` Keith Mannthey
2006-08-09 1:03 ` Andi Kleen
2006-08-09 1:27 ` Rusty Russell
2006-08-06 19:15 ` Andrew Morton
2006-08-07 2:06 ` Andi Kleen
2006-08-07 2:54 ` Rusty Russell
2006-08-07 2:55 ` Andi Kleen
2006-08-07 3:08 ` Rusty Russell
2006-08-07 3:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0608061811030.19637@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®