From: Patrick Boettcher <patrick.boettcher@desy.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: v4l-dvb maintainer list <v4l-dvb-maintainer@linuxtv.org>,
linux-kernel@vger.kernel.org
Subject: Re: drivers/media/dvb/dvb-usb/dibusb-mb.c: NULL dereference
Date: Tue, 15 Aug 2006 16:43:23 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0608151635360.30902@pub2.ifh.de> (raw)
In-Reply-To: <20060814231528.GY3543@stusta.de>
Hi Adrian,
On Tue, 15 Aug 2006, Adrian Bunk wrote:
> The Coverity checker spotted the following "we dereference d->fe only
> when we know it's NULL" bug:
>
> <-- snip -->
>
> ...
> static int dibusb_dib3000mb_frontend_attach(struct dvb_usb_device *d)
> {
> ...
> if ((d->fe = dib3000mb_attach(&demod_cfg,&d->i2c_adap,&st->ops)) == NULL) {
> d->fe->ops.tuner_ops.init = dvb_usb_tuner_init_i2c;
> d->fe->ops.tuner_ops.set_params = dvb_usb_tuner_set_params_i2c;
> return -ENODEV;
> }
> ...
>
> <-- snip -->
Oops, this one was introduced in rev 3124 of the v4l-dvb repository when
adding tuner_ops.
Mauro, can you please pull from http://linuxtv.org/hg/~pb/v4l-dvb to get
the fix.
For the others: the changeset is here:
http://linuxtv.org/hg/~pb/v4l-dvb?cmd=changeset;node=ac1c589c56fc018f14fdf74c274d8438a8566b69;style=raw
regards,
Patrick.
--
Mail: patrick.boettcher@desy.de
WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/
prev parent reply other threads:[~2006-08-15 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-14 23:15 Adrian Bunk
2006-08-15 14:43 ` Patrick Boettcher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0608151635360.30902@pub2.ifh.de \
--to=patrick.boettcher@desy.de \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®