From: James Morris <jmorris@namei.org>
To: Akinobu Mita <mita@miraclelinux.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Patrick McHardy <kaber@trash.net>,
David Miller <davem@davemloft.net>,
akpm@osdl.org
Subject: Re: call panic if nl_table allocation fails
Date: Wed, 23 Aug 2006 10:06:25 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0608231003340.3198@d.namei> (raw)
In-Reply-To: <20060823113740.GA7834@miraclelinux.com>
On Wed, 23 Aug 2006, Akinobu Mita wrote:
> This patch makes crash happen if initialization of nl_table fails
> in initcalls. It is better than getting use after free crash later.
> nl_table = kcalloc(MAX_LINKS, sizeof(*nl_table), GFP_KERNEL);
Perhaps it'd be better to declare this as an array rather than allocating
it at runtime.
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2006-08-23 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 11:37 Akinobu Mita
2006-08-23 14:06 ` James Morris [this message]
2006-08-23 14:17 ` Patrick McHardy
2006-08-29 9:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0608231003340.3198@d.namei \
--to=jmorris@namei.org \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mita@miraclelinux.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®