From: James Morris <jmorris@namei.org>
To: gerrit@erg.abdn.ac.uk
Cc: davem@davemloft.net, alan@lxorguk.ukuu.org.uk,
kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, kaber@coreworks.de,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 1/3] net/ipv4: UDP-Lite extensions
Date: Wed, 23 Aug 2006 10:22:24 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0608231019010.3198@d.namei> (raw)
In-Reply-To: <200608231150.42039@strip-the-willow>
On Wed, 23 Aug 2006, gerrit@erg.abdn.ac.uk wrote:
> +void __init udplite4_register(void)
> +{
> + if (proto_register(&udplite_prot, 1))
> + goto out_register_err;
> +
> + if (inet_add_protocol(&udplite_protocol, IPPROTO_UDPLITE) < 0)
> + goto out_unregister_proto;
> +
> + inet_register_protosw(&udplite4_protosw);
> +
> + return;
> +
> +out_unregister_proto:
> + proto_unregister(&udplite_prot);
> +out_register_err:
> + printk(KERN_ERR "udplite4_register: Cannot add UDP-Lite protocol\n");
> +}
Other protocols & network components call panic() if they fail during boot
initialization. Not sure if this is a great thing, but it raises the
issue of whether udp-lite should remain consistent here.
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2006-08-23 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 10:50 gerrit
2006-08-23 14:22 ` James Morris [this message]
2006-08-23 15:03 ` gerrit
2006-08-23 15:22 ` James Morris
2006-08-23 19:45 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0608231019010.3198@d.namei \
--to=jmorris@namei.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=kaber@coreworks.de \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®