From: Christoph Lameter <clameter@sgi.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Dave Hansen <haveblue@us.ibm.com>
Subject: Re: [PATCH] zone table removal miss merge
Date: Wed, 27 Sep 2006 09:19:00 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0609270911060.9171@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20060927112315.GA8093@shadowen.org>
On Wed, 27 Sep 2006, Andy Whitcroft wrote:
> The below should fix it.
Acked-by: Christoph Lameter <clameter@sgi.com>
Note that if ZONE_DMA is off then ZONES_WIDTH may become
0 and therefore also ZONES_PGSHIFT is zero.
If you then do
#define ZONEID_PGSHIFT ZONES_PGSHIFT
then ZONEID_PGSHIFT will be 0!
So this could be an issue for the optional ZONE_DMA patch.
Could you also make sure that ZONEID_PGSHIFT is set correctly even if
ZONES_WIDTH is zero?
This affects the optional ZONE_DMA patch. zone table removal should be
fine with just the above patch.
prev parent reply other threads:[~2006-09-27 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060927021934.9461b867.akpm@osdl.org>
2006-09-27 11:23 ` Andy Whitcroft
2006-09-27 16:19 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0609270911060.9171@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®