From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
trivial@kernel.org
Subject: Re: [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug().
Date: Tue, 10 Oct 2006 07:35:42 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0610100732350.7386@localhost.localdomain> (raw)
In-Reply-To: <1160479883.3000.284.camel@laptopd505.fenrus.org>
On Tue, 10 Oct 2006, Arjan van de Ven wrote:
> On Tue, 2006-10-10 at 07:17 -0400, Robert P. J. Day wrote:
> > Simplify the definition of IXGB_DBG() to be based on pr_debug().
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> > ---
> > diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
> > index 50ffe90..16e6c3d 100644
> > --- a/drivers/net/ixgb/ixgb.h
> > +++ b/drivers/net/ixgb/ixgb.h
> > @@ -77,11 +77,7 @@ #include "ixgb_hw.h"
> > #include "ixgb_ee.h"
> > #include "ixgb_ids.h"
> >
> > -#ifdef _DEBUG_DRIVER_
> > -#define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
> > -#else
> > -#define IXGB_DBG(args...)
> > -#endif
> > +#define IXGB_DBG(args...) pr_debug("ixgb: ", args)
>
>
> while this is of course correct, why not go all the way and replace all
> IXGB() users to pr_debug() directly?
fair enough, i can do that. back later.
rday
prev parent reply other threads:[~2006-10-10 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 11:17 Robert P. J. Day
2006-10-10 11:31 ` Arjan van de Ven
2006-10-10 11:35 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0610100732350.7386@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®