From: Hugh Dickins <hugh@veritas.com>
To: Paulo Marques <pmarques@grupopie.com>
Cc: Rik Bobbaers <Rik.Bobbaers@cc.kuleuven.be>,
linux-kernel@vger.kernel.org, linux-mm@vger.kernel.org
Subject: Re: very small code cleanup
Date: Tue, 7 Nov 2006 15:11:29 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0611071505040.6764@blonde.wat.veritas.com> (raw)
In-Reply-To: <45509B97.2080104@grupopie.com>
On Tue, 7 Nov 2006, Paulo Marques wrote:
> Rik Bobbaers wrote:
> >
> > in mm/mlock.c , mm is defined as vma->vm_mm, why not use that one for the
> > decrement of pages?
>
> Because vma can change here:
>
> if (*prev) {
> vma = *prev;
> goto success;
> }
That's a good piece of cautious observation ...
>
> and then mm won't be the same as vma->vm_mm..
... but it would be a bug if *prev's vm_mm were different from mm
and from the original vma->vm_mm: Rik's patch looks sensible to me.
Hugh
prev parent reply other threads:[~2006-11-07 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-07 14:30 Rik Bobbaers
2006-11-07 14:43 ` Paulo Marques
2006-11-07 15:11 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0611071505040.6764@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=Rik.Bobbaers@cc.kuleuven.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=pmarques@grupopie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®