From: Christoph Lameter <clameter@sgi.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@kernel.org, akpm@osdl.org
Subject: Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
Date: Tue, 7 Nov 2006 18:01:11 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0611071800250.7749@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20061108105648.4a149cca.kamezawa.hiroyu@jp.fujitsu.com>
On Wed, 8 Nov 2006, KAMEZAWA Hiroyuki wrote:
> > pm[nr_pages].node = MAX_NUMNODES;
>
> I think node0 is always online...but this should be
>
> pm[i].node = first_online_node; // /* any online node */
No it is a marker. The use of any node that is online could lead to a
false determination of the endpoint of the list.
next prev parent reply other threads:[~2006-11-08 2:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 3:42 Stephen Rothwell
2006-11-03 5:13 ` Christoph Lameter
2006-11-05 22:23 ` patch fix-sys_move_pages-when-a-null-node-list-is-passed.patch queued to -stable tree chrisw
2006-11-08 1:56 ` [PATCH] Fix sys_move_pages when a NULL node list is passed KAMEZAWA Hiroyuki
2006-11-08 2:01 ` Christoph Lameter [this message]
2006-11-08 2:13 ` KAMEZAWA Hiroyuki
2006-11-08 2:47 ` Stephen Rothwell
2006-11-08 2:57 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0611071800250.7749@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sfr@canb.auug.org.au \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®